[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187753#comment-17187753
]
Szilard Nemeth commented on YARN-10342:
---
Thanks [~gandras] for working on this.
Latest patch LGTM,
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177990#comment-17177990
]
Hadoop QA commented on YARN-10342:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177786#comment-17177786
]
Bilwa S T commented on YARN-10342:
--
Thanks [~gandras] for updating patch. +1(Non-binding)
> [UI1]
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177733#comment-17177733
]
Andras Gyori commented on YARN-10342:
-
Thank you [~BilwaST]. I have addressed your latest comment and
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172371#comment-17172371
]
Hadoop QA commented on YARN-10342:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172206#comment-17172206
]
Bilwa S T commented on YARN-10342:
--
Thanks [~gandras] for updating it. I had one more comment.
can we
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172144#comment-17172144
]
Andras Gyori commented on YARN-10342:
-
Thank you [~BilwaST] for the feedback, a good catch, fixed the
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171655#comment-17171655
]
Bilwa S T commented on YARN-10342:
--
Thanks [~gandras] for the patch.
I have a following comments
1.
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167517#comment-17167517
]
Hadoop QA commented on YARN-10342:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167477#comment-17167477
]
Hadoop QA commented on YARN-10342:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167305#comment-17167305
]
Andras Gyori commented on YARN-10342:
-
Thank you [~snemeth] and [~bteke] for the feedbacks. I have
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166981#comment-17166981
]
Szilard Nemeth commented on YARN-10342:
---
Hi [~gandras],
Patch LGTM, only one thing is missing:
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162127#comment-17162127
]
Benjamin Teke commented on YARN-10342:
--
Agreed, let's keep it simple. LGTM (non-binding)
> [UI1]
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158094#comment-17158094
]
Andras Gyori commented on YARN-10342:
-
Thank you [~bteke] for the review! Though I would agree with
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156836#comment-17156836
]
Benjamin Teke commented on YARN-10342:
--
Hi [~gandras],
Thanks for the patch!
A nit: getting the
[
https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154502#comment-17154502
]
Andras Gyori commented on YARN-10342:
-
A patch has been uploaded, which puts a constraint on the
16 matches
Mail list logo