[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0 and allow more lenient capacity checks in Capacity Scheduler

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234778#comment-17234778 ] Hadoop QA commented on YARN-10486: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0 and allow more lenient capacity checks in Capacity Scheduler

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234751#comment-17234751 ] Szilard Nemeth commented on YARN-10486: --- Thanks for working on this [~pbacsko] , I checked the

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234634#comment-17234634 ] Hadoop QA commented on YARN-10486: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234560#comment-17234560 ] Benjamin Teke commented on YARN-10486: -- Patch 008 seems good to me, +1 (non-binding). > FS-CS

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234493#comment-17234493 ] Benjamin Teke commented on YARN-10486: -- Hi [~pbacsko], A small nit about the latest patch (007): in 

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234349#comment-17234349 ] Hadoop QA commented on YARN-10486: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234296#comment-17234296 ] Peter Bacsko commented on YARN-10486: - " In this case maybe the property name should be more telling,

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233545#comment-17233545 ] Benjamin Teke commented on YARN-10486: -- Thanks [~pbacsko]. _Note that there are two places in

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233471#comment-17233471 ] Hadoop QA commented on YARN-10486: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233306#comment-17233306 ] Peter Bacsko commented on YARN-10486: - Todo: this comment needs to be fixed {noformat} *

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233298#comment-17233298 ] Peter Bacsko commented on YARN-10486: - Thanks [~bteke] let's proceed with approach #2. I made

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232902#comment-17232902 ] Benjamin Teke commented on YARN-10486: -- Also as discussed offline it would be good to add an extra

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232736#comment-17232736 ] Benjamin Teke commented on YARN-10486: -- Hi [~pbacsko],   Thanks for the patches/approaches. While

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231799#comment-17231799 ] Hadoop QA commented on YARN-10486: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231573#comment-17231573 ] Hadoop QA commented on YARN-10486: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230116#comment-17230116 ] Hadoop QA commented on YARN-10486: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230101#comment-17230101 ] Hadoop QA commented on YARN-10486: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229464#comment-17229464 ] Hadoop QA commented on YARN-10486: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10486) FS-CS converter: handle case when weight=0

[ https://issues.apache.org/jira/browse/YARN-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229337#comment-17229337 ] Peter Bacsko commented on YARN-10486: - Uploaded patch v1 to see if everything is alright. Todo: 1.