[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307114#comment-17307114
]
Jim Brennan commented on YARN-10697:
Thanks for the update [~BilwaST]! I am +1 on patch 003.
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306970#comment-17306970
]
Hadoop QA commented on YARN-10697:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306824#comment-17306824
]
Bilwa S T commented on YARN-10697:
--
[~Jim_Brennan] I have changed method name. Please check updated
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306489#comment-17306489
]
Jim Brennan commented on YARN-10697:
Thanks for the update [~BilwaST]! +1 patch 002 looks good to
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305422#comment-17305422
]
Hadoop QA commented on YARN-10697:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305380#comment-17305380
]
Bilwa S T commented on YARN-10697:
--
Hi [~Jim_Brennan]
I have attached .002 patch with latest changes.
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304941#comment-17304941
]
Jim Brennan commented on YARN-10697:
{quote}
So can we introduce a new method in Resource.java which
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304629#comment-17304629
]
Bilwa S T commented on YARN-10697:
--
Thanks [~Jim_Brennan] [~jhung] for your comments.
I basically added
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304467#comment-17304467
]
Jonathan Hung commented on YARN-10697:
--
[~Jim_Brennan] [~BilwaST] I agree, I don't think we should
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303747#comment-17303747
]
Jim Brennan commented on YARN-10697:
[~BilwaST] I agree about the bug in
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303260#comment-17303260
]
Hadoop QA commented on YARN-10697:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303123#comment-17303123
]
Bilwa S T commented on YARN-10697:
--
[~epayne] [~jbrennan] can you please take a look at this?
>
[
https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303120#comment-17303120
]
Bilwa S T commented on YARN-10697:
--
In YARN-10251 in if case they removed multiplying by BYTES_IN_MB
13 matches
Mail list logo