[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316612#comment-17316612
]
Hadoop QA commented on YARN-10702:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316478#comment-17316478
]
Jim Brennan commented on YARN-10702:
Thanks again [~ebadger]! I put up additional patches for
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315597#comment-17315597
]
Jim Brennan commented on YARN-10702:
The failed unit test for branch-3.3 is unrelated. Looks like it
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315251#comment-17315251
]
Hadoop QA commented on YARN-10702:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315196#comment-17315196
]
Jim Brennan commented on YARN-10702:
Thanks [~ebadger]! I have put up a patch for branch-3.3.
> Add
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315191#comment-17315191
]
Eric Badger commented on YARN-10702:
[~Jim_Brennan], thanks for the patch. +1 I've committed this to
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314912#comment-17314912
]
Jim Brennan commented on YARN-10702:
Not going to fix these checkstyle issues, because the new
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314671#comment-17314671
]
Hadoop QA commented on YARN-10702:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314651#comment-17314651
]
Jim Brennan commented on YARN-10702:
patch 006 addresses the checkstyle/spotbug issues.
> Add
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314131#comment-17314131
]
Hadoop QA commented on YARN-10702:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314086#comment-17314086
]
Jim Brennan commented on YARN-10702:
Patch 005 adds a configuration property for this:
{noformat}
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311321#comment-17311321
]
Qi Zhu commented on YARN-10702:
---
Thanks [~Jim_Brennan] for update.
The update LGTM, and i agree this
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305110#comment-17305110
]
Jim Brennan commented on YARN-10702:
Thanks for the suggestions [~gandras]! I agree this should be
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305033#comment-17305033
]
Andras Gyori commented on YARN-10702:
-
Thank you [~Jim_Brennan] for the contribution! The logic is
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304408#comment-17304408
]
Hadoop QA commented on YARN-10702:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304387#comment-17304387
]
Hadoop QA commented on YARN-10702:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304250#comment-17304250
]
Jim Brennan commented on YARN-10702:
Jumped the gun. Patch 004 has fixes for the other checkstyle
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304240#comment-17304240
]
Jim Brennan commented on YARN-10702:
Thanks for the review [~zhuqi]! patch 003 fixes the method
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303809#comment-17303809
]
Qi Zhu commented on YARN-10702:
---
Thanks [~Jim_Brennan] for this.
It makes sense to me, and it's a very
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303777#comment-17303777
]
Hadoop QA commented on YARN-10702:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303724#comment-17303724
]
Jim Brennan commented on YARN-10702:
patch 002 is rebased to current trunk.
> Add cluster metric for
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303697#comment-17303697
]
Jim Brennan commented on YARN-10702:
Attaching some images of how this looks on the RM legacy UI and
[
https://issues.apache.org/jira/browse/YARN-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303691#comment-17303691
]
Hadoop QA commented on YARN-10702:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
23 matches
Mail list logo