[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-31 Thread Sandy Ryza (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955762#comment-13955762 ] Sandy Ryza commented on YARN-1889: -- +1 avoid creating new objects on each fair scheduler

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-30 Thread Hong Zhiguo (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954925#comment-13954925 ] Hong Zhiguo commented on YARN-1889: --- Hi, Fengdong, I didn't submit new patch yet and I'll

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954931#comment-13954931 ] Hadoop QA commented on YARN-1889: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-30 Thread Fengdong Yu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954945#comment-13954945 ] Fengdong Yu commented on YARN-1889: --- The new patch looks good to me. avoid creating new

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-29 Thread Fengdong Yu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951778#comment-13951778 ] Fengdong Yu commented on YARN-1889: --- Hi, Zhiguo, what my comments you addressed in your

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950576#comment-13950576 ] Hadoop QA commented on YARN-1889: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-28 Thread Sandy Ryza (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951002#comment-13951002 ] Sandy Ryza commented on YARN-1889: -- Another nit: Priority.newInstance should be used

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-28 Thread Sandy Ryza (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950999#comment-13950999 ] Sandy Ryza commented on YARN-1889: -- When you say gc pressure, which is going down? The

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-28 Thread Fengdong Yu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950749#comment-13950749 ] Fengdong Yu commented on YARN-1889: --- Good catch, Zhiguo. can you add some test cases in

[jira] [Commented] (YARN-1889) avoid creating new objects on each fair scheduler call to AppSchedulable comparator

2014-03-28 Thread Hong Zhiguo (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951774#comment-13951774 ] Hong Zhiguo commented on YARN-1889: --- Hi, Sandy, During processing NodeUpdate events, the