[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852859#comment-16852859
]
Prashant Gour commented on YARN-2185:
-
In this ticket there are changes made in RunJar.java where in a
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347067#comment-16347067
]
Hudson commented on YARN-2185:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13588 (See
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347030#comment-16347030
]
Jason Lowe commented on YARN-2185:
--
+1 lgtm. Committing this.
> Use pipes when localizing archives
>
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346053#comment-16346053
]
genericqa commented on YARN-2185:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345961#comment-16345961
]
Miklos Szegedi commented on YARN-2185:
--
~[~rohithsharma] I am sorry about the inconvenience.
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345191#comment-16345191
]
Hudson commented on YARN-2185:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13582 (See
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344605#comment-16344605
]
Rohith Sharma K S commented on YARN-2185:
-
This is breaking in secured cluster with permission
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341972#comment-16341972
]
Miklos Szegedi commented on YARN-2185:
--
Thank you for the reviews [~jlowe], [~grepas] and [~rkanter]
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341505#comment-16341505
]
Hudson commented on YARN-2185:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13566 (See
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341471#comment-16341471
]
Jason Lowe commented on YARN-2185:
--
The mvn install failure appears to be a hiccup with the SNAPSHOT jars
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340393#comment-16340393
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340296#comment-16340296
]
Jason Lowe commented on YARN-2185:
--
Thanks for updating the patch! Looks good to me. I noticed the QA
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338655#comment-16338655
]
genericqa commented on YARN-2185:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338524#comment-16338524
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338403#comment-16338403
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338279#comment-16338279
]
Miklos Szegedi commented on YARN-2185:
--
Thank you, [~jlowe]. I updated the patch.
{quote}makeShellPath
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337856#comment-16337856
]
Jason Lowe commented on YARN-2185:
--
Thanks for updating the patch! I think it's very close now.
bq. I
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337005#comment-16337005
]
Miklos Szegedi commented on YARN-2185:
--
I opened YARN-7803 for the unit test error.
> Use pipes when
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335356#comment-16335356
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335245#comment-16335245
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335173#comment-16335173
]
Miklos Szegedi commented on YARN-2185:
--
Thank you for the review [~jlowe]!
bq. If the subprocess ends
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334872#comment-16334872
]
Jason Lowe commented on YARN-2185:
--
Thanks for updating the patch!
Should a
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333145#comment-16333145
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333122#comment-16333122
]
Robert Kanter commented on YARN-2185:
-
+1 LGTM
[~jlowe] any other comments?
> Use pipes when
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333038#comment-16333038
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332965#comment-16332965
]
Miklos Szegedi commented on YARN-2185:
--
Thank you for the review [~rkanter]. I updated the patch.
>
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332948#comment-16332948
]
Robert Kanter commented on YARN-2185:
-
Thanks for the update [~miklos.szeg...@cloudera.com].
One last
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331691#comment-16331691
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331605#comment-16331605
]
Miklos Szegedi commented on YARN-2185:
--
The deprecated message is expected, the unit test error is
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331569#comment-16331569
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331435#comment-16331435
]
Miklos Szegedi commented on YARN-2185:
--
Thank you for the review [~rkanter]. I updated the patch.
>
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331335#comment-16331335
]
Robert Kanter commented on YARN-2185:
-
Here's some comments:
# The do-while loop in {{RunJar#unJar}}
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331129#comment-16331129
]
Miklos Szegedi commented on YARN-2185:
--
I intentionally added the javac warning, so that we deprecate
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331101#comment-16331101
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324545#comment-16324545
]
Jason Lowe commented on YARN-2185:
--
Thanks for updating the patch!
bq. I was wondering, if it should be
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321307#comment-16321307
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319663#comment-16319663
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319446#comment-16319446
]
Miklos Szegedi commented on YARN-2185:
--
Thank you for the review, [~jlowe] and [~grepas].
bq. This
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316777#comment-16316777
]
Jason Lowe commented on YARN-2185:
--
Thanks for the patch!
This patch adds parallel copying of directories
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316339#comment-16316339
]
Gergo Repas commented on YARN-2185:
---
Thanks [~miklos.szeg...@cloudera.com].
+1 (non-binding)
> Use pipes
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312332#comment-16312332
]
Miklos Szegedi commented on YARN-2185:
--
The findbugs issue is in trunk.
> Use pipes when localizing
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312313#comment-16312313
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307944#comment-16307944
]
Gergo Repas commented on YARN-2185:
---
Thanks [~miklos.szeg...@cloudera.com] for the patch, I like this
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305943#comment-16305943
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302207#comment-16302207
]
genericqa commented on YARN-2185:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299199#comment-16299199
]
Miklos Szegedi commented on YARN-2185:
--
Based on our discussion offline I can spend a few cycles on
46 matches
Mail list logo
