[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738773#comment-14738773
]
Nathan Roberts commented on YARN-2410:
--
Thanks for the additional code comments. +1
> Nodemanager
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738973#comment-14738973
]
Jason Lowe commented on YARN-2410:
--
+1 for the latest patch. Committing this.
> Nodemanager
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736946#comment-14736946
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737112#comment-14737112
]
Jason Lowe commented on YARN-2410:
--
Thanks for updating the patch. I see now that since Shuffle is not a
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736960#comment-14736960
]
Kuhu Shukla commented on YARN-2410:
---
[~jlowe] Thank you so much for the comments. I have updated the
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737902#comment-14737902
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737349#comment-14737349
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737574#comment-14737574
]
Jason Lowe commented on YARN-2410:
--
+1 latest patch looks good to me. Will commit tomorrow if there are
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737463#comment-14737463
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737470#comment-14737470
]
Kuhu Shukla commented on YARN-2410:
---
[~jlowe], thank you for your comments. I regret the oversight.
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737654#comment-14737654
]
Nathan Roberts commented on YARN-2410:
--
One minor comment. If it's not too much trouble, could you add
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735766#comment-14735766
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734931#comment-14734931
]
Jason Lowe commented on YARN-2410:
--
Thanks for updating the patch!
bq. The only reason was findbugs which
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733149#comment-14733149
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731501#comment-14731501
]
Jason Lowe commented on YARN-2410:
--
Thanks for the patch, Kuhu!
Do we really need getShuffle/setShuffle
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727927#comment-14727927
]
Kuhu Shukla commented on YARN-2410:
---
Requesting [~nroberts] , [~jlowe] , [~jeagles] for their
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660496#comment-14660496
]
Kuhu Shukla commented on YARN-2410:
---
Requesting [~nroberts] and [~jlowe] to review the
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660592#comment-14660592
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642138#comment-14642138
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628840#comment-14628840
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626622#comment-14626622
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626717#comment-14626717
]
Hadoop QA commented on YARN-2410:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617108#comment-14617108
]
Kuhu Shukla commented on YARN-2410:
---
[~airbots] Are you working on this JIRA? If not, I
23 matches
Mail list logo
