[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258337#comment-14258337 ] Hudson commented on YARN-2937: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2002 (See [htt

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258320#comment-14258320 ] Hudson commented on YARN-2937: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #52 (See

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258291#comment-14258291 ] Hudson commented on YARN-2937: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #48 (See [http

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258276#comment-14258276 ] Hudson commented on YARN-2937: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1983 (See [https://

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258196#comment-14258196 ] Hudson commented on YARN-2937: -- FAILURE: Integrated in Hadoop-Yarn-trunk #785 (See [https://b

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258189#comment-14258189 ] Hudson commented on YARN-2937: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #51 (See [http

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258022#comment-14258022 ] Varun Saxena commented on YARN-2937: Thanks [~zjshen] for the rebase, review and commit

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257954#comment-14257954 ] Hudson commented on YARN-2937: -- FAILURE: Integrated in Hadoop-trunk-Commit #6786 (See [https:

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257898#comment-14257898 ] Hadoop QA commented on YARN-2937: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257848#comment-14257848 ] Zhijie Shen commented on YARN-2937: --- +1 for the last patch. Will commit it. > Fix new fi

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257525#comment-14257525 ] Hadoop QA commented on YARN-2937: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257430#comment-14257430 ] Varun Saxena commented on YARN-2937: {code} } finally { if (pw != null) { boolean

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257427#comment-14257427 ] Varun Saxena commented on YARN-2937: bq. IMHO, we can simply throw it at finally block.

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257414#comment-14257414 ] Zhijie Shen commented on YARN-2937: --- IMHO, we can simply throw it at finally block. It's

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257404#comment-14257404 ] Varun Saxena commented on YARN-2937: [~zjshen], I think it can be changed as under. Bec

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257371#comment-14257371 ] Varun Saxena commented on YARN-2937: [~zjshen], however you are correct that as {{Print

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257361#comment-14257361 ] Varun Saxena commented on YARN-2937: [~zjshen], yes I had got your point. What I meant

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257302#comment-14257302 ] Zhijie Shen commented on YARN-2937: --- bq. Havent thrown Exception in code below though, as

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257098#comment-14257098 ] Varun Saxena commented on YARN-2937: [~zjshen], kindly review. Have rebased the patch.

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257081#comment-14257081 ] Hadoop QA commented on YARN-2937: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256993#comment-14256993 ] Varun Saxena commented on YARN-2937: [~zjshen], above piece of code is in finally block

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256994#comment-14256994 ] Varun Saxena commented on YARN-2937: [~zjshen], above piece of code is in finally block

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-22 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256229#comment-14256229 ] Zhijie Shen commented on YARN-2937: --- [~varun_saxena], thanks for your explanation, which

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246124#comment-14246124 ] Varun Saxena commented on YARN-2937: [~zjshen], addressed your comments in a new patch.

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246123#comment-14246123 ] Hadoop QA commented on YARN-2937: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-13 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245801#comment-14245801 ] Varun Saxena commented on YARN-2937: bq. And yes, BufferedReader will close the underly

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-12 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245160#comment-14245160 ] Varun Saxena commented on YARN-2937: [~zjshen], bq. What's the problem around Random?

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-12 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244628#comment-14244628 ] Zhijie Shen commented on YARN-2937: --- 1. What's the problem around Random? {code} -Ran

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-11 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243752#comment-14243752 ] Varun Saxena commented on YARN-2937: [~zjshen], can you review this one as well ? > Fi

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243381#comment-14243381 ] Hadoop QA commented on YARN-2937: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243187#comment-14243187 ] Hadoop QA commented on YARN-2937: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-10 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241929#comment-14241929 ] Varun Saxena commented on YARN-2937: Weird...Why are HDFS tests being run for a Yarn pa

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241922#comment-14241922 ] Hadoop QA commented on YARN-2937: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240078#comment-14240078 ] Hadoop QA commented on YARN-2937: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager

2014-12-09 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240056#comment-14240056 ] Varun Saxena commented on YARN-2937: These test case failures may have to do with using