[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849230#comment-13849230 ] Junping Du commented on YARN-311: - Thanks Bikas for comments! Please see my reply: bq. Sorry

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849263#comment-13849263 ] Junping Du commented on YARN-311: - Filed YARN-1508 for addressing rename and documentation

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849278#comment-13849278 ] Bikas Saha commented on YARN-311: - Sounds good! Dynamic node resource configuration: core

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848615#comment-13848615 ] Bikas Saha commented on YARN-311: - Sorry for coming in so late on this. Some javadoc on

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814787#comment-13814787 ] Hudson commented on YARN-311: - SUCCESS: Integrated in Hadoop-Yarn-trunk #384 (See

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814859#comment-13814859 ] Hudson commented on YARN-311: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1601 (See

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814478#comment-13814478 ] Junping Du commented on YARN-311: - Thanks Luke for review! Dynamic node resource

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813139#comment-13813139 ] Luke Lu commented on YARN-311: -- [~djp]: Unfortunately YARN-1343 got in before I tried to merge

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813547#comment-13813547 ] Junping Du commented on YARN-311: - Sure. Will update patch soon. Thx! Dynamic node

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813574#comment-13813574 ] Junping Du commented on YARN-311: - Updated in v13 patch. Dynamic node resource

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813661#comment-13813661 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811714#comment-13811714 ] Luke Lu commented on YARN-311: -- v12 patch lgtm. +1. Will commit soon. Dynamic node resource

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809781#comment-13809781 ] Hadoop QA commented on YARN-311: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809797#comment-13809797 ] Junping Du commented on YARN-311: - The log didn't show it is an build failure (it works well

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809820#comment-13809820 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13807773#comment-13807773 ] Luke Lu commented on YARN-311: -- Junping: your [previous

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808027#comment-13808027 ] Junping Du commented on YARN-311: - Hi Luke, Thanks for comments. bq. 1.Requiring RMNode

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808130#comment-13808130 ] Luke Lu commented on YARN-311: -- IMO, using an immutable ResourceOption object is cleaner than

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808353#comment-13808353 ] Junping Du commented on YARN-311: - The problem is even we involve ResourceOption, it is

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808557#comment-13808557 ] Luke Lu commented on YARN-311: -- With ResourceOption, you don't need a separate

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808577#comment-13808577 ] Junping Du commented on YARN-311: - Luke, thanks for comments! That's also doable, but I have

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808600#comment-13808600 ] Luke Lu commented on YARN-311: -- bq. How it sounds to you? Sounds good to me :), assuming

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808757#comment-13808757 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13807484#comment-13807484 ] Luke Lu commented on YARN-311: -- I share the same concern with Bikas with the RMNode lock inside

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13807505#comment-13807505 ] Junping Du commented on YARN-311: - Luke, the volatile is not enough as you cannot set

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805522#comment-13805522 ] Bikas Saha commented on YARN-311: - Can we please double check and assure ourselves that this

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1380#comment-1380 ] Junping Du commented on YARN-311: - Thanks for comments, Bikas! The synchronization here is

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804038#comment-13804038 ] Luke Lu commented on YARN-311: -- v9 patch lgtm. +1. For the record, we've discussed the changes

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804320#comment-13804320 ] Luke Lu commented on YARN-311: -- [~djp]: Upon second thought, I think we should improve the

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804335#comment-13804335 ] Luke Lu commented on YARN-311: -- We can probably infer the option by an overcommit timeout

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804465#comment-13804465 ] Junping Du commented on YARN-311: - Thanks Luke for review and comments! Yes. We discussed

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804532#comment-13804532 ] Luke Lu commented on YARN-311: -- bq. Other policies/options will be addressed in YARN-999

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804690#comment-13804690 ] Junping Du commented on YARN-311: - Luke, instead of void setTotalCapacity(Resource resource,

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804719#comment-13804719 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803534#comment-13803534 ] Junping Du commented on YARN-311: - Hi [~vinodkv] and [~vicaya], would you help to review it

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797463#comment-13797463 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13777171#comment-13777171 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766141#comment-13766141 ] Junping Du commented on YARN-311: - Thanks Luke for review and comments!

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766787#comment-13766787 ] Arun C Murthy commented on YARN-311: Can I get a few more days to review this? Thanks.

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767095#comment-13767095 ] Junping Du commented on YARN-311: - Sure. Thanks for review. Arun! Dynamic

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765760#comment-13765760 ] Luke Lu commented on YARN-311: -- I think the v6.2 patch looks reasonable. If there is no further

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759722#comment-13759722 ] Junping Du commented on YARN-311: - [~tucu00], would you help to review it again? Thx!

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757710#comment-13757710 ] Junping Du commented on YARN-311: - Thanks for review! [~tucu00] bq. If we make

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757791#comment-13757791 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756599#comment-13756599 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756614#comment-13756614 ] Alejandro Abdelnur commented on YARN-311: - * the patch as a few false changes

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756634#comment-13756634 ] Junping Du commented on YARN-311: - Hi, [~tucu00] Thanks for comments! bq.

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756674#comment-13756674 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757256#comment-13757256 ] Hadoop QA commented on YARN-311: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes

[ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683044#comment-13683044 ] Junping Du commented on YARN-311: - According to discussion above, let's split JMX api into a