[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393351#comment-14393351
]
zhihai xu commented on YARN-3415:
-
[~sandyr], thanks for the review, The latest patch
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391738#comment-14391738
]
Rohit Agarwal commented on YARN-3415:
-
+1
Non-AM containers can be counted towards
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391972#comment-14391972
]
Hadoop QA commented on YARN-3415:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391728#comment-14391728
]
zhihai xu commented on YARN-3415:
-
[~ragarwal], thanks for the review. I uploaded a new
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391218#comment-14391218
]
Sandy Ryza commented on YARN-3415:
--
+1
Non-AM containers can be counted towards
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391624#comment-14391624
]
Sandy Ryza commented on YARN-3415:
--
[~ragarwal] did you have any more comments before I
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391674#comment-14391674
]
Rohit Agarwal commented on YARN-3415:
-
It looks good.
I have one minor comment:
{code}
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388262#comment-14388262
]
Hadoop QA commented on YARN-3415:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388285#comment-14388285
]
zhihai xu commented on YARN-3415:
-
[~sandyr], that is a very good idea to move the call to
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388387#comment-14388387
]
Hadoop QA commented on YARN-3415:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387425#comment-14387425
]
Sandy Ryza commented on YARN-3415:
--
This looks mostly reasonable. A few comments:
* In
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387763#comment-14387763
]
Rohit Agarwal commented on YARN-3415:
-
I don't understand the newly added tests:
{code}
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386042#comment-14386042
]
Hadoop QA commented on YARN-3415:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386048#comment-14386048
]
zhihai xu commented on YARN-3415:
-
The test failure is due to HADOOP-11754
{code}
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385672#comment-14385672
]
zhihai xu commented on YARN-3415:
-
[~ragarwal], thanks for the comment.
bq. 1. If the above
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386003#comment-14386003
]
zhihai xu commented on YARN-3415:
-
I uploaded a patch YARN-3415.000.patch for review.
The
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385347#comment-14385347
]
Sandy Ryza commented on YARN-3415:
--
Thanks for filing this [~ragarwal] and for taking this
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385192#comment-14385192
]
zhihai xu commented on YARN-3415:
-
It looks like we should also check isAmRunning at
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385202#comment-14385202
]
Rohit Agarwal commented on YARN-3415:
-
if (!isAmRunning() getLiveContainers().size()
[
https://issues.apache.org/jira/browse/YARN-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385185#comment-14385185
]
zhihai xu commented on YARN-3415:
-
I can work on this issue, I read the problem at
20 matches
Mail list logo
