[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610668#comment-14610668
]
Varun Saxena commented on YARN-3508:
[~leftnoteasy], the timed out test
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610788#comment-14610788
]
Wangda Tan commented on YARN-3508:
--
Thanks for update, [~varun_saxena].
Checkstyle is
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611238#comment-14611238
]
Wangda Tan commented on YARN-3508:
--
Committing..
Preemption processing occuring on the
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611232#comment-14611232
]
Jian He commented on YARN-3508:
---
lgtm, thanks [~varun_saxena] !
Preemption processing
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609402#comment-14609402
]
Hadoop QA commented on YARN-3508:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608746#comment-14608746
]
Varun Saxena commented on YARN-3508:
[~leftnoteasy], yes this is what the patch does
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608797#comment-14608797
]
Wangda Tan commented on YARN-3508:
--
I think my comment confusing you:
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608729#comment-14608729
]
Wangda Tan commented on YARN-3508:
--
Thanks for explanation, [~varun_saxena].
Currently,
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608986#comment-14608986
]
Wangda Tan commented on YARN-3508:
--
bq. Ok, IIUC you want me to pass RMContext to
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608870#comment-14608870
]
Varun Saxena commented on YARN-3508:
bq. Instead of passing EventHandlerSchedulerEvent
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608911#comment-14608911
]
Varun Saxena commented on YARN-3508:
Any reason you want this changed ? Even if we pass
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609215#comment-14609215
]
Hadoop QA commented on YARN-3508:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609080#comment-14609080
]
Varun Saxena commented on YARN-3508:
[~leftnoteasy],
bq. Init is used by production
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609096#comment-14609096
]
Varun Saxena commented on YARN-3508:
BTW, as we are passing RMContext into
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606576#comment-14606576
]
Wangda Tan commented on YARN-3508:
--
[~varun_saxena],
It seems to me this patch doesn't
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606379#comment-14606379
]
Hadoop QA commented on YARN-3508:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606618#comment-14606618
]
Varun Saxena commented on YARN-3508:
[~leftnoteasy], the test failures seem unrelated.
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606619#comment-14606619
]
Varun Saxena commented on YARN-3508:
I mean,
We can open an interface for posting
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606653#comment-14606653
]
Hadoop QA commented on YARN-3508:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602474#comment-14602474
]
Varun Saxena commented on YARN-3508:
[~leftnoteasy], ok if thats the consensus, I will
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601884#comment-14601884
]
Varun Saxena commented on YARN-3508:
[~jlowe]/[~jianhe]/[~leftnoteasy]/[~rohithsharma],
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601947#comment-14601947
]
Wangda Tan commented on YARN-3508:
--
I tent to support [~jlowe] and [~jianhe]'s suggestion,
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577021#comment-14577021
]
Varun Saxena commented on YARN-3508:
Just to clarify, in the implementation I have
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577026#comment-14577026
]
Rohith commented on YARN-3508:
--
The problem I see in the clubbing with scheduler events is if
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574935#comment-14574935
]
Jian He commented on YARN-3508:
---
I think this make sense to move preemption events from main
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574753#comment-14574753
]
Jason Lowe commented on YARN-3508:
--
Yes, it's not a cure-all to move the preemption
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573878#comment-14573878
]
Wangda Tan commented on YARN-3508:
--
Trying to better understand this problem: I'm not sure
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566469#comment-14566469
]
Varun Saxena commented on YARN-3508:
Checkstyle is showing incorrect result it seems.
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566509#comment-14566509
]
Hadoop QA commented on YARN-3508:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565929#comment-14565929
]
Hadoop QA commented on YARN-3508:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564007#comment-14564007
]
Hadoop QA commented on YARN-3508:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
31 matches
Mail list logo