[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586135#comment-15586135
]
Li Lu commented on YARN-3816:
-
+1. And we can separate the work of taking average from YARN-4821 if that can
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586102#comment-15586102
]
Sangjin Lee commented on YARN-3816:
---
I think we should do YARN-4821 in any case for a number of reasons,
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585160#comment-15585160
]
Varun Saxena commented on YARN-3816:
bq. What you've mention here, IIUC, is something closer to the
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584034#comment-15584034
]
Li Lu commented on YARN-3816:
-
Created YARN-5747 for a fix on the aggregation problem. This fix should be
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584027#comment-15584027
]
Li Lu commented on YARN-3816:
-
bq. Currently they emit them every 3 seconds, but I think we should do a time
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584012#comment-15584012
]
Sangjin Lee commented on YARN-3816:
---
{quote}
Would it be better to use time weighted average for
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583958#comment-15583958
]
Li Lu commented on YARN-3816:
-
Hi [~varun_saxena], please see my comments inline...
bq. We do not aggregate the
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580259#comment-15580259
]
Varun Saxena commented on YARN-3816:
[~gtCarrera9], [~sjlee0], few questions.
# We do not aggregate the
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369793#comment-15369793
]
Hudson commented on YARN-3816:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252880#comment-15252880
]
Sangjin Lee commented on YARN-3816:
---
Understood. I commented because I thought that entities that should
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252716#comment-15252716
]
Li Lu commented on YARN-3816:
-
Thanks [~sjlee0]. Some quick note on the design: the goal here is to let each
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252492#comment-15252492
]
Sangjin Lee commented on YARN-3816:
---
We're almost there...
It appears that
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252458#comment-15252458
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252263#comment-15252263
]
Li Lu commented on YARN-3816:
-
Thanks [~sjlee0]! Took a look at it. The test failure happened when we read
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252202#comment-15252202
]
Sangjin Lee commented on YARN-3816:
---
This is somewhat unrelated to the TestHBaseTimelineStorage failure
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251279#comment-15251279
]
Sangjin Lee commented on YARN-3816:
---
I'm also unable to reproduce the TestHBaseTimelineStorage failure.
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251259#comment-15251259
]
Li Lu commented on YARN-3816:
-
BTW, the HBase storage UT failure looks a little bit weird. Is this an
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251229#comment-15251229
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250918#comment-15250918
]
Li Lu commented on YARN-3816:
-
Thanks [~sjlee0]. I'm still fighting with the javadoc issues and opened two
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250905#comment-15250905
]
Sangjin Lee commented on YARN-3816:
---
The latest patch looks good for the most part, minus the javadoc
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250707#comment-15250707
]
Li Lu commented on YARN-3816:
-
OK, I'm working with the javadoc warnings. Seems like each time I can only get
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249352#comment-15249352
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248866#comment-15248866
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246736#comment-15246736
]
Sangjin Lee commented on YARN-3816:
---
Thanks for updating the patch [~gtCarrera9]!
It appears that the
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240324#comment-15240324
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238407#comment-15238407
]
Sangjin Lee commented on YARN-3816:
---
Thanks [~gtCarrera9] for the quick update!
As for the new metric
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237628#comment-15237628
]
Li Lu commented on YARN-3816:
-
Thanks for the pointer Sangjin! Sure let's not use column names for aggregation
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237606#comment-15237606
]
Sangjin Lee commented on YARN-3816:
---
Sorry I missed the column post-fix part earlier in my review.
>
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237602#comment-15237602
]
Sangjin Lee commented on YARN-3816:
---
We discussed the cases where we may need to support adding more info
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237548#comment-15237548
]
Li Lu commented on YARN-3816:
-
Thanks [~varun_saxena] and [~sjlee0]! My bottomline is we may want to store
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237487#comment-15237487
]
Sangjin Lee commented on YARN-3816:
---
I had a similar question to Varun. Is there another way to handle
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237024#comment-15237024
]
Varun Saxena commented on YARN-3816:
Had a quick scan of the patch. There seems to be multiple
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236671#comment-15236671
]
Li Lu commented on YARN-3816:
-
I'm about to finish refreshing the patch but then realized this patch conflicts
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231612#comment-15231612
]
Sangjin Lee commented on YARN-3816:
---
[~gtCarrera9], thanks much for posting an updated patch for this! I
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227600#comment-15227600
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208443#comment-15208443
]
Junping Du commented on YARN-3816:
--
Sorry guys. I was planning to finish it a few month ago but we had
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207995#comment-15207995
]
Varun Saxena commented on YARN-3816:
[~sjlee0],
Maybe in Thursday's meeting, we can revisit open 1st
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207889#comment-15207889
]
Li Lu commented on YARN-3816:
-
[~sjlee0] cool. Let me catch up on the patch and restart the work. I believe
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207880#comment-15207880
]
Sangjin Lee commented on YARN-3816:
---
Hi [~gtCarrera9], yes, absolutely. I understand Junping's time has
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207862#comment-15207862
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207570#comment-15207570
]
Li Lu commented on YARN-3816:
-
Going through the 1st milestone list and found we haven't touched this issue
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068490#comment-15068490
]
Sangjin Lee commented on YARN-3816:
---
Just to clarify, it appears both aggregated (but not accumulated
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067330#comment-15067330
]
Sangjin Lee commented on YARN-3816:
---
Regarding the new entity type "YARN_APPLICATION_AGGREGATION", I
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067321#comment-15067321
]
Sangjin Lee commented on YARN-3816:
---
It seems the latest patch (v.4.1) is mostly a rebase change, so I'll
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067340#comment-15067340
]
Sangjin Lee commented on YARN-3816:
---
Right. There was a discussion around YARN-4053 on the column names
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061858#comment-15061858
]
Varun Saxena commented on YARN-3816:
bq. Former value can be used to represent how much resources the
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062254#comment-15062254
]
Varun Saxena commented on YARN-3816:
[~djp],
Regarding using postfix in column qualifier to indicate
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062392#comment-15062392
]
Junping Du commented on YARN-3816:
--
Thanks [~varun_saxena] for comments. I don't think we have any
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062425#comment-15062425
]
Varun Saxena commented on YARN-3816:
[~djp], I was actually not talking about Sangjin's comment above.
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062464#comment-15062464
]
Varun Saxena commented on YARN-3816:
Just to elaborate further, the main thing is that if we keep on
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056362#comment-15056362
]
Junping Du commented on YARN-3816:
--
Thanks [~sjlee0], [~varun_saxena] and Li's comments. I am rebase the
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056817#comment-15056817
]
Li Lu commented on YARN-3816:
-
Thanks for the explanations [~djp]! With regard to my question:
bq. There are 3
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053435#comment-15053435
]
Li Lu commented on YARN-3816:
-
One precaution: seems like some changes in this JIRA is conflicting with
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049536#comment-15049536
]
Li Lu commented on YARN-3816:
-
Thanks for the update [~djp]! I went through an earlier version of the patch a
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038169#comment-15038169
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037947#comment-15037947
]
Hadoop QA commented on YARN-3816:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14877294#comment-14877294
]
Varun Saxena commented on YARN-3816:
By the way, calculating area under the curve along the time
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876928#comment-14876928
]
Sangjin Lee commented on YARN-3816:
---
My apologies for truly belated review comments. I just had time to
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875824#comment-14875824
]
Hadoop QA commented on YARN-3816:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875811#comment-14875811
]
Hadoop QA commented on YARN-3816:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791775#comment-14791775
]
Varun Saxena commented on YARN-3816:
[~djp],
{quote}
In TimelineMetric#accumulateTo, can latestMetric
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14802848#comment-14802848
]
Varun Saxena commented on YARN-3816:
I mean for TIME_SERIES we can take value associated with latest
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803140#comment-14803140
]
Hadoop QA commented on YARN-3816:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14802995#comment-14802995
]
Hadoop QA commented on YARN-3816:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14802985#comment-14802985
]
Hadoop QA commented on YARN-3816:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14802898#comment-14802898
]
Junping Du commented on YARN-3816:
--
bq. This is more from the context of caller. I am not sure if Li's
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791012#comment-14791012
]
Junping Du commented on YARN-3816:
--
Thanks Naga, Varun and Li for review and comments! Let me address them
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791374#comment-14791374
]
Junping Du commented on YARN-3816:
--
Reply to Varun's comments:
bq. In TimelineMetric#accumulateTo, can
[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791580#comment-14791580
]
Hadoop QA commented on YARN-3816:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
69 matches
Mail list logo
