[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438922#comment-15438922
]
Rohith Sharma K S commented on YARN-3940:
-
+1LGTM
> Application moveToQueue should check NodeLabel
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438377#comment-15438377
]
Naganarasimha G R commented on YARN-3940:
-
[~sunilg] & [~rohithsharma], if no other comments on the
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436360#comment-15436360
]
Hadoop QA commented on YARN-3940:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436235#comment-15436235
]
Sunil G commented on YARN-3940:
---
That makes sense. Thanks [~bibinchundatt]
> Application moveToQueue should
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436231#comment-15436231
]
Bibin A Chundatt commented on YARN-3940:
[~sunilg]
Will add as a comment that all labels in life
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436200#comment-15436200
]
Sunil G commented on YARN-3940:
---
Sorry for pitching in late.
I thought of discussing a scenario here. I know
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435528#comment-15435528
]
Naganarasimha G R commented on YARN-3940:
-
Thanks for pointing it out [~rohithsharma], just cross
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435472#comment-15435472
]
Rohith Sharma K S commented on YARN-3940:
-
Unexpectedly I focused on this JIRA. And got interest to
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435390#comment-15435390
]
Naganarasimha G R commented on YARN-3940:
-
Thanks for the patch [~bibinchundatt], +1 LGTM,
Will
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434535#comment-15434535
]
Hadoop QA commented on YARN-3940:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433672#comment-15433672
]
Naganarasimha G R commented on YARN-3940:
-
Hi [~bibinchundatt],
{code}
boolean isValidrequest =
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431237#comment-15431237
]
Hadoop QA commented on YARN-3940:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120731#comment-15120731
]
Wangda Tan commented on YARN-3940:
--
I think you can take a look at
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106437#comment-15106437
]
Bibin A Chundatt commented on YARN-3940:
Hi [~leftnoteasy], Could you please review patch attached.
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089764#comment-15089764
]
Hadoop QA commented on YARN-3940:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087686#comment-15087686
]
Hadoop QA commented on YARN-3940:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088779#comment-15088779
]
Bibin A Chundatt commented on YARN-3940:
Hi [~Naganarasimha]
Thank you for review .I have already
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085917#comment-15085917
]
Bibin A Chundatt commented on YARN-3940:
Uploading patch after fixing check style issue. Please do
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085963#comment-15085963
]
Hadoop QA commented on YARN-3940:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085972#comment-15085972
]
Sunil G commented on YARN-3940:
---
Thanks [~bibinchundatt]
Few comments:
1. {{ LeafQueue dest}} --> {{
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085828#comment-15085828
]
Hadoop QA commented on YARN-3940:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086195#comment-15086195
]
Hadoop QA commented on YARN-3940:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073930#comment-15073930
]
Bibin A Chundatt commented on YARN-3940:
Hi [~leftnoteasy]
Sorry for delayed response.
But if
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680272#comment-14680272
]
Bibin A Chundatt commented on YARN-3940:
[~leftnoteasy] Any thoughts??
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680538#comment-14680538
]
Wangda Tan commented on YARN-3940:
--
[~bibinchundatt],
Rethink about this, I think to make
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648939#comment-14648939
]
Bibin A Chundatt commented on YARN-3940:
For first case mentioned above
Will check
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648686#comment-14648686
]
Bibin A Chundatt commented on YARN-3940:
Hi [~leftnoteasy]
Thank you for review
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647955#comment-14647955
]
Wangda Tan commented on YARN-3940:
--
[~bibinchundatt],
I took a look at the patch, it
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641914#comment-14641914
]
Hadoop QA commented on YARN-3940:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641769#comment-14641769
]
Hadoop QA commented on YARN-3940:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633847#comment-14633847
]
Wangda Tan commented on YARN-3940:
--
I just converted this to sub-task of YARN-2492 for
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633870#comment-14633870
]
Bibin A Chundatt commented on YARN-3940:
[~leftnoteasy] IMO ,Since the destination
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633876#comment-14633876
]
Wangda Tan commented on YARN-3940:
--
[~bibinchundatt], I agree with you. One approach is in
[
https://issues.apache.org/jira/browse/YARN-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633881#comment-14633881
]
Bibin A Chundatt commented on YARN-3940:
[~leftnoteasy] Thnks for comment will
34 matches
Mail list logo
