[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117289#comment-16117289
]
Wangda Tan commented on YARN-4161:
--
Test failure is not related, pushing this to branch-2.
> Capacity
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117270#comment-16117270
]
Hadoop QA commented on YARN-4161:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117002#comment-16117002
]
Wangda Tan commented on YARN-4161:
--
Committed to trunk, thanks [~ywskycn] and reviews from [~sunilg].
>
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113155#comment-16113155
]
Sunil G commented on YARN-4161:
---
Thanks [~ywskycn]
That clarifies my doubt.. multiple-assignments-enabled is
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113123#comment-16113123
]
Wei Yan commented on YARN-4161:
---
Yes, here we introduce one more condition check. But by default, the new
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112855#comment-16112855
]
Sunil G commented on YARN-4161:
---
Extremely sorry for sharing a quick doubt last moment here.
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110150#comment-16110150
]
Sunil G commented on YARN-4161:
---
+1 LGTM
> Capacity Scheduler : Assign single or multiple containers per
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109907#comment-16109907
]
Wangda Tan commented on YARN-4161:
--
And reassigned to [~ywskycn].
> Capacity Scheduler : Assign single
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109905#comment-16109905
]
Wangda Tan commented on YARN-4161:
--
Latest patch looks good, +1, will commit tomorrow if nobody against.
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109725#comment-16109725
]
Wei Yan commented on YARN-4161:
---
[~sunilg] could u help review the latest patch? :) thanks.
> Capacity
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102031#comment-16102031
]
Sunil G commented on YARN-4161:
---
Yes. Test case failures are unrelated. I will check latest patch and will
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102021#comment-16102021
]
Wei Yan commented on YARN-4161:
---
The TestDelegationTokenRenewer test error looks un-related. [~sunilg], any
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100661#comment-16100661
]
Hadoop QA commented on YARN-4161:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098133#comment-16098133
]
Sunil G commented on YARN-4161:
---
One doubt:
I think we are not checking below condition in
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095165#comment-16095165
]
Wei Yan commented on YARN-4161:
---
The failed testcase passed locally, looks like not related to this patch.
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093897#comment-16093897
]
Hadoop QA commented on YARN-4161:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093868#comment-16093868
]
Wangda Tan commented on YARN-4161:
--
Thanks [~ywskycn], in general the patch looks good to me. And could
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093777#comment-16093777
]
Hadoop QA commented on YARN-4161:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093485#comment-16093485
]
Hadoop QA commented on YARN-4161:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086786#comment-16086786
]
Sunil G commented on YARN-4161:
---
[~ywskycn] could u please help to rebase the patch
> Capacity Scheduler :
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086778#comment-16086778
]
Hadoop QA commented on YARN-4161:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068963#comment-16068963
]
Sunil G commented on YARN-4161:
---
bq,Yes. so you ok with existing two config fields?
Yes. We can do two
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068542#comment-16068542
]
Wei Yan commented on YARN-4161:
---
{quote}
I got your point. I was trying to point out to an existing
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067360#comment-16067360
]
Sunil G commented on YARN-4161:
---
I got your point. I was trying to point out to an existing configuration in
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067299#comment-16067299
]
Wei Yan commented on YARN-4161:
---
Thanks for the comments [~sunilg].
For the configuration names, I followed
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067270#comment-16067270
]
Sunil G commented on YARN-4161:
---
Thanks [~ywskycn] for rebasing the patch.
Few high level comments
# Could
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065803#comment-16065803
]
Wangda Tan commented on YARN-4161:
--
Thanks [~ywskycn] for the patch, [~sunilg] could you help review the
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613484#comment-15613484
]
Min Shen commented on YARN-4161:
The patch does not apply to trunk.
[~mayank_bansal], could you please
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083867#comment-15083867
]
Hadoop QA commented on YARN-4161:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967311#comment-14967311
]
winghc commented on YARN-4161:
--
we just encountered this problem when we submit large job in our production
[
https://issues.apache.org/jira/browse/YARN-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745907#comment-14745907
]
Wangda Tan commented on YARN-4161:
--
This will be very useful, thanks [~mayank_bansal]. Converted this to
31 matches
Mail list logo
