[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215603#comment-16215603
]
Hadoop QA commented on YARN-4163:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215469#comment-16215469
]
Hudson commented on YARN-4163:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13121 (See
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215426#comment-16215426
]
Eric Payne commented on YARN-4163:
--
Thanks [~jlowe] and [~lichangleo]. I will commit this to trunk,
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213011#comment-16213011
]
Jason Lowe commented on YARN-4163:
--
Thanks for updating the patch!
+1 lgtm.
> Audit getQueueInfo and
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209494#comment-16209494
]
Eric Payne commented on YARN-4163:
--
The unit tests are passing for me in my local environment.
> Audit
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208609#comment-16208609
]
Hadoop QA commented on YARN-4163:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202180#comment-16202180
]
Jason Lowe commented on YARN-4163:
--
Thanks for updating the patch! The builder pattern solves the
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193857#comment-16193857
]
Hadoop QA commented on YARN-4163:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193354#comment-16193354
]
Hadoop QA commented on YARN-4163:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193102#comment-16193102
]
Eric Payne commented on YARN-4163:
--
OK, so there are still some valid checkstyle warnings. Interestingly,
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193084#comment-16193084
]
Hadoop QA commented on YARN-4163:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190317#comment-16190317
]
Jason Lowe commented on YARN-4163:
--
Thanks for updating the patch!
It would be good to cleanup the
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186230#comment-16186230
]
Hadoop QA commented on YARN-4163:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179253#comment-16179253
]
Eric Payne commented on YARN-4163:
--
[~lichangleo], please let me know if you plan on up-merging the patch
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986168#comment-14986168
]
Hadoop QA commented on YARN-4163:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983771#comment-14983771
]
Hadoop QA commented on YARN-4163:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876041#comment-14876041
]
Chang Li commented on YARN-4163:
broken unit tests are unrelated.
> Audit getQueueInfo and getApplications
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790980#comment-14790980
]
Hadoop QA commented on YARN-4163:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790754#comment-14790754
]
Chang Li commented on YARN-4163:
The broken unit test is unrelated to my change. Have test this test on my
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746544#comment-14746544
]
Hadoop QA commented on YARN-4163:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746349#comment-14746349
]
Chang Li commented on YARN-4163:
[~jlowe] please help review.
> Audit getQueueInfo and getApplications
21 matches
Mail list logo