[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369787#comment-15369787 ] Hudson commented on YARN-4178: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946465#comment-14946465 ] Varun Saxena commented on YARN-4178: Thanks for the commit [~sjlee0] and others for the reviews >

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945480#comment-14945480 ] Varun Saxena commented on YARN-4178: Ok. But then should we rename the other one as invertLong ? >

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945475#comment-14945475 ] Sangjin Lee commented on YARN-4178: --- The latest patch looks good to me for the most part. I just had one

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945485#comment-14945485 ] Sangjin Lee commented on YARN-4178: --- That's fine too. I'm comfortable either way (invert/invertInt vs.

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945776#comment-14945776 ] Vrushali C commented on YARN-4178: -- Patch v5 looks good to me too. > [storage implementation] app id as

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945643#comment-14945643 ] Hadoop QA commented on YARN-4178: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945750#comment-14945750 ] Sangjin Lee commented on YARN-4178: --- The latest patch LGTM. I'll wait a little while before I commit to

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943703#comment-14943703 ] Sangjin Lee commented on YARN-4178: --- +1 with consolidating WriterUtils and ReaderUtils. > [storage

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943778#comment-14943778 ] Vrushali C commented on YARN-4178: -- bq. I think we can have a single class TimelineStorageUtils and remove

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943863#comment-14943863 ] Varun Saxena commented on YARN-4178: Depending on order in which patches go in, YARN-4178 or YARN-3864

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943957#comment-14943957 ] Sangjin Lee commented on YARN-4178: --- I just committed YARN-3864. Could you please rebase this patch?

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943973#comment-14943973 ] Hadoop QA commented on YARN-4178: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942973#comment-14942973 ] Varun Saxena commented on YARN-4178: bq. To that effect, if you’d like, we can rename

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942972#comment-14942972 ] Varun Saxena commented on YARN-4178: bq. Why do we need any util classes for this, can't an AppId class

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944130#comment-14944130 ] Varun Saxena commented on YARN-4178: New patch updated. > [storage implementation] app id as string in

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944123#comment-14944123 ] Hadoop QA commented on YARN-4178: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944190#comment-14944190 ] Hadoop QA commented on YARN-4178: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938953#comment-14938953 ] Vrushali C commented on YARN-4178: -- Thanks [~varun_saxena] for the patch. Overall, LGTM. A couple of

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939315#comment-14939315 ] Joep Rottinghuis commented on YARN-4178: Fine starting without it with benefit of more compact

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934954#comment-14934954 ] Varun Saxena commented on YARN-4178: bq. As for the "application" prefix, is there a discussion in the

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934934#comment-14934934 ] Varun Saxena commented on YARN-4178: Ok...Will change it. > [storage implementation] app id as string

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935922#comment-14935922 ] Hadoop QA commented on YARN-4178: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935530#comment-14935530 ] Varun Saxena commented on YARN-4178: That's a good point. Yes, would need to handle it. As you said,

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935531#comment-14935531 ] Varun Saxena commented on YARN-4178: That's a good point. Yes, would need to handle it. As you said,

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935493#comment-14935493 ] Sangjin Lee commented on YARN-4178: --- I think the only (minor) concern is if we did not store the prefix

[jira] [Commented] (YARN-4178) [storage implementation] app id as string in row keys can cause incorrect ordering

[ https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934442#comment-14934442 ] Sangjin Lee commented on YARN-4178: --- Thanks [~varun_saxena] for the proposed patch. I'm generally in