[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074393#comment-15074393 ] Karthik Kambatla commented on YARN-4257: [~leftnoteasy] - really appreciate the ping, haven't seen

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074424#comment-15074424 ] Wangda Tan commented on YARN-4257: -- Corrected JIRA id in my last comment: YARN-1408 -> YARN-1488 > Move

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074435#comment-15074435 ] Rich Haase commented on YARN-4257: -- [~leftnoteasy] Agreed. Doesn't make sense to change validateConf if

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074399#comment-15074399 ] Karthik Kambatla commented on YARN-4257: Just read the remainder of the description regarding

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074422#comment-15074422 ] Wangda Tan commented on YARN-4257: -- Thanks [~kasha]/[~rhaase], 0 resource makes sense to me if container

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074404#comment-15074404 ] Rich Haase commented on YARN-4257: -- [~kasha] I can update the patch to revert the changes to the

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074334#comment-15074334 ] Wangda Tan commented on YARN-4257: -- Thanks [~rhaase], Patch looks good to me. [~kasha], since the patch

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073179#comment-15073179 ] Hadoop QA commented on YARN-4257: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073189#comment-15073189 ] Rich Haase commented on YARN-4257: -- The failing tests don't appear to be related to this patch. Not sure

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073044#comment-15073044 ] Wangda Tan commented on YARN-4257: -- Hi [~rhaase], I didn't see patch attached to this JIRA, could you

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073053#comment-15073053 ] Rich Haase commented on YARN-4257: -- Just uploaded the fixed patch. I found a couple import changes that

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073003#comment-15073003 ] Rich Haase commented on YARN-4257: -- Hi [~wangda], I'm uploading a patch that tests out in my local build

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064886#comment-15064886 ] Wangda Tan commented on YARN-4257: -- Hi [~rhaase], Thanks for working on this patch, Patch looks good to

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061808#comment-15061808 ] Sunil G commented on YARN-4257: --- Looks like the patch is wrong. There are many unwanted changes such as

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062545#comment-15062545 ] Hadoop QA commented on YARN-4257: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062558#comment-15062558 ] Rich Haase commented on YARN-4257: -- Reviewing failed tests. > Move scheduler validateConf method to

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062590#comment-15062590 ] Rich Haase commented on YARN-4257: -- I've uploaded a new patch that removes the failing tests for zero MB

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062915#comment-15062915 ] Hadoop QA commented on YARN-4257: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061938#comment-15061938 ] Hadoop QA commented on YARN-4257: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060808#comment-15060808 ] Rich Haase commented on YARN-4257: -- Makes sense to me. > Move scheduler validateConf method to

[jira] [Commented] (YARN-4257) Move scheduler validateConf method to AbstractYarnScheduler and make it protected

[ https://issues.apache.org/jira/browse/YARN-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046067#comment-15046067 ] Wangda Tan commented on YARN-4257: -- IMHO, minimum-allocation-mb shouldn't be zero in any cases. zero-sized