[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369753#comment-15369753
]
Hudson commented on YARN-4446:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131564#comment-15131564
]
Varun Saxena commented on YARN-4446:
Thanks [~sjlee0] for the review and commit.
> Refactor reader API
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130974#comment-15130974
]
Sangjin Lee commented on YARN-4446:
---
+1. I'll commit it soon. Please let me know now if you have any
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128962#comment-15128962
]
Hadoop QA commented on YARN-4446:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128870#comment-15128870
]
Varun Saxena commented on YARN-4446:
Addressed comments and attached a new patch.
> Refactor reader
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129140#comment-15129140
]
Hadoop QA commented on YARN-4446:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129203#comment-15129203
]
Sangjin Lee commented on YARN-4446:
---
There seem to be new javadoc errors and a fixable checkstyle
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129767#comment-15129767
]
Varun Saxena commented on YARN-4446:
The 3 checkstyle issues cant be fixed.
2 of them are related to
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128590#comment-15128590
]
Sangjin Lee commented on YARN-4446:
---
{quote}
We are using context to fill UID after we have retrieved
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126988#comment-15126988
]
Sangjin Lee commented on YARN-4446:
---
Thanks [~varun_saxena] for your patch!
I generally agree with the
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127812#comment-15127812
]
Varun Saxena commented on YARN-4446:
bq. I think the rule of thumb is, the impact of any changes to
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126552#comment-15126552
]
Varun Saxena commented on YARN-4446:
Kindly review.
3 of the checkstyle issues cant be fixed.
>
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124442#comment-15124442
]
Varun Saxena commented on YARN-4446:
Fixed one checkstyle issue which could be fixed.
> Refactor
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124465#comment-15124465
]
Hadoop QA commented on YARN-4446:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124193#comment-15124193
]
Hadoop QA commented on YARN-4446:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054318#comment-15054318
]
Varun Saxena commented on YARN-4446:
After YARN-3863, getEntities API would change to as under :
{code}
16 matches
Mail list logo
