[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376098#comment-15376098 ] Hadoop QA commented on YARN-4759: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-13 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376031#comment-15376031 ] Shane Kumpf commented on YARN-4759: --- Thanks for the review [~vvasudev]! I will upload a new patch

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-13 Thread Varun Vasudev (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375435#comment-15375435 ] Varun Vasudev commented on YARN-4759: - Thanks for the patch [~shaneku...@gmail.com]. Patch looks mostly

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-12 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374138#comment-15374138 ] Shane Kumpf commented on YARN-4759: --- The two remaining checkstyle errors are because the package names

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374132#comment-15374132 ] Hadoop QA commented on YARN-4759: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-12 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373617#comment-15373617 ] Shane Kumpf commented on YARN-4759: --- working on a new patch to fix cc and checkstyle issues. > Revisit

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373588#comment-15373588 ] Hadoop QA commented on YARN-4759: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-12 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373071#comment-15373071 ] Shane Kumpf commented on YARN-4759: --- In my dev environment, I find it very useful to be able to keep

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-07-11 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370847#comment-15370847 ] Shane Kumpf commented on YARN-4759: --- I've started working on this again and have a patch ready based on

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-04-14 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241924#comment-15241924 ] Shane Kumpf commented on YARN-4759: --- After considering the options for ensuring graceful stop of

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-04-14 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241919#comment-15241919 ] Shane Kumpf commented on YARN-4759: --- As I understand it, you are correct, all of the processes will be

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-03-30 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218532#comment-15218532 ] Vinod Kumar Vavilapalli commented on YARN-4759: --- bq. To complicate matters, the docker client

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-03-23 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208622#comment-15208622 ] Shane Kumpf commented on YARN-4759: --- Also of note, we should propagate the return code that killed the

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-03-23 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208603#comment-15208603 ] Shane Kumpf commented on YARN-4759: --- We need to use docker client commands to signal to processes in

[jira] [Commented] (YARN-4759) Revisit signalContainer() for docker containers

2016-03-09 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187259#comment-15187259 ] Shane Kumpf commented on YARN-4759: --- I'd like to work on this and will be taking ownership. > Revisit