[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2019-11-21 Thread Hu Ziqian (Jira)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979115#comment-16979115 ] Hu Ziqian commented on YARN-4766: - hi [~haibochen], should you tell me what's problem this issue try to

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300561#comment-15300561 ] Hudson commented on YARN-4766: -- SUCCESS: Integrated in Hadoop-trunk-Commit #9859 (See

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-24 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299196#comment-15299196 ] Robert Kanter commented on YARN-4766: - +1 LGTM. Will commit sometime tomorrow morning. > NM should

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296933#comment-15296933 ] Hadoop QA commented on YARN-4766: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-23 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296653#comment-15296653 ] Haibo Chen commented on YARN-4766: -- The checkstyle warnings are against the protobuf-generated file. I'll

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-22 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295767#comment-15295767 ] Robert Kanter commented on YARN-4766: - [~haibochen], the 005 patch looks good to me. Can you take a

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292277#comment-15292277 ] Hadoop QA commented on YARN-4766: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-19 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292217#comment-15292217 ] Haibo Chen commented on YARN-4766: -- Thanks Ray for your comment, the name you suggested is much better.

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-18 Thread Ray Chiang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289743#comment-15289743 ] Ray Chiang commented on YARN-4766: -- Minor nit: Rename noMoreRetentionLogFiles to

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-09 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276598#comment-15276598 ] Haibo Chen commented on YARN-4766: -- findbug issue is unrelated to my patch > NM should not aggregate logs

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-05-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273156#comment-15273156 ] Hadoop QA commented on YARN-4766: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-04-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259224#comment-15259224 ] Hadoop QA commented on YARN-4766: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-04-26 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259159#comment-15259159 ] Robert Kanter commented on YARN-4766: - Thanks Haibo. For #6, that's what I was getting at. +1

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-04-22 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254624#comment-15254624 ] Haibo Chen commented on YARN-4766: -- @Robert Kanter, thanks very much for your review. I have addressed all

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-04-21 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253086#comment-15253086 ] Robert Kanter commented on YARN-4766: - Looks good overall. Here's a few things: #

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-03-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200863#comment-15200863 ] Hadoop QA commented on YARN-4766: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-03-18 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200655#comment-15200655 ] Haibo Chen commented on YARN-4766: -- fixed the liscense + checkstyle issues. The unit test failure is

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-03-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194670#comment-15194670 ] Hadoop QA commented on YARN-4766: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4766) NM should not aggregate logs older than the retention policy

2016-03-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194303#comment-15194303 ] Hadoop QA commented on YARN-4766: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||