[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218892#comment-15218892
]
Wangda Tan commented on YARN-4822:
--
Thanks [~jianhe]/[~sunilg] for review and commit!
> Refactor existing
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218708#comment-15218708
]
Hudson commented on YARN-4822:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9527 (See
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218255#comment-15218255
]
Sunil G commented on YARN-4822:
---
Thanks [~leftnoteasy]
Latest patch looks good for me. +1.
> Refactor
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217307#comment-15217307
]
Sunil G commented on YARN-4822:
---
bq.This looks fine to me actually, since check only takes O(1).
Yes, its
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217016#comment-15217016
]
Hadoop QA commented on YARN-4822:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216790#comment-15216790
]
Wangda Tan commented on YARN-4822:
--
Hi [~sunilg],
bq. In that case, could we mark Interface visibility as
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216641#comment-15216641
]
Sunil G commented on YARN-4822:
---
Thanks [~leftnoteasy].
Yes, That make sense.
1.
In that case, could we
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216524#comment-15216524
]
Wangda Tan commented on YARN-4822:
--
[~sunilg],
Thanks for comments,
bq. One more comment here, can we
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216064#comment-15216064
]
Sunil G commented on YARN-4822:
---
Thanks [~leftnoteasy] for the clarifications. I think going forward if we
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215105#comment-15215105
]
Wangda Tan commented on YARN-4822:
--
Test failure is not related, no CS changes in this patch. Filed
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215089#comment-15215089
]
Hadoop QA commented on YARN-4822:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214676#comment-15214676
]
Jian He commented on YARN-4822:
---
- SchedulingEditPolicy interface should not be changed as it is
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214420#comment-15214420
]
Wangda Tan commented on YARN-4822:
--
Hi [~sunilg],
bq. I am not much getting much idea abt the use of
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214377#comment-15214377
]
Sunil G commented on YARN-4822:
---
Hi [~leftnoteasy]
Thank you very much for doing this work item. Its looking
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214004#comment-15214004
]
Hadoop QA commented on YARN-4822:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213770#comment-15213770
]
Jian He commented on YARN-4822:
---
A few naming suggestions:
- PPCP#preemptableEntities -> preemptableQueues
-
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210417#comment-15210417
]
Sunil G commented on YARN-4822:
---
Thanks [~leftnoteasy] for this initiative.
I started looking in to this, I
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209733#comment-15209733
]
Hadoop QA commented on YARN-4822:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209469#comment-15209469
]
Wangda Tan commented on YARN-4822:
--
[~eepayne], [~sunilg], [~jianhe],
Appreciate if you could take a look
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207920#comment-15207920
]
Hadoop QA commented on YARN-4822:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207458#comment-15207458
]
Hadoop QA commented on YARN-4822:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200526#comment-15200526
]
Hadoop QA commented on YARN-4822:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
22 matches
Mail list logo