[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332736#comment-16332736
]
Hudson commented on YARN-5094:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13525 (See
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332604#comment-16332604
]
Haibo Chen commented on YARN-5094:
--
Thanks [~rohithsharma] for the review. Will commit it shortly.
> some
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332598#comment-16332598
]
Rohith Sharma K S commented on YARN-5094:
-
I cross confirmed that it only happens for NM publishing
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332573#comment-16332573
]
Rohith Sharma K S commented on YARN-5094:
-
Yes, we need this to get in. Patch looks fine to me. I
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332482#comment-16332482
]
Haibo Chen commented on YARN-5094:
--
+1 on fixing it. [~rohithsharma] [~sunilg] [~vrushalic]
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331994#comment-16331994
]
genericqa commented on YARN-5094:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331894#comment-16331894
]
Sunil G commented on YARN-5094:
---
Container finished time is coming as -1 when new UI pulls container data
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133989#comment-16133989
]
Hadoop QA commented on YARN-5094:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035301#comment-16035301
]
Haibo Chen commented on YARN-5094:
--
Will look into it and follow up with a new patch
> some YARN
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035296#comment-16035296
]
Vrushali C commented on YARN-5094:
--
Thanks [~haibochen] for the patch. Do you think we might want to put
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035282#comment-16035282
]
Haibo Chen commented on YARN-5094:
--
Findbug warnings are unrelated.
> some YARN container events have
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035259#comment-16035259
]
Hadoop QA commented on YARN-5094:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035116#comment-16035116
]
Haibo Chen commented on YARN-5094:
--
Will update the patch to address the unit test failures.
> some YARN
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033935#comment-16033935
]
Haibo Chen commented on YARN-5094:
--
Thanks [~gtCarrera9] for your comments. Yes, I have limited the change
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033917#comment-16033917
]
Hadoop QA commented on YARN-5094:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033890#comment-16033890
]
Li Lu commented on YARN-5094:
-
Sorry about the delay. Please feel free to take it. Let's not touch
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033878#comment-16033878
]
Haibo Chen commented on YARN-5094:
--
Sorry, I just realized that AbstractEvent is used in everywhere. To be
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033262#comment-16033262
]
Haibo Chen commented on YARN-5094:
--
As indicated in the comments above, YARN-5169 is the real cause. I am
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003537#comment-16003537
]
Haibo Chen commented on YARN-5094:
--
[~gtCarrera9] Do you mind if I take over? I am looking at YARN-5169,
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317326#comment-15317326
]
Sangjin Lee commented on YARN-5094:
---
I don't believe this should block the merge. Please let me know if
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303432#comment-15303432
]
Sangjin Lee commented on YARN-5094:
---
When YARN-5169 is fixed, we can pick it up by rebasing with the
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303431#comment-15303431
]
Sangjin Lee commented on YARN-5094:
---
Filed YARN-5169.
We discussed this offline, and I believe this is
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302668#comment-15302668
]
Hadoop QA commented on YARN-5094:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302514#comment-15302514
]
Varun Saxena commented on YARN-5094:
Personally I would have slightly preferred timestamps to be filled
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297290#comment-15297290
]
Sangjin Lee commented on YARN-5094:
---
Yes, I'm also slightly leaning towards populating the timestamp
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296707#comment-15296707
]
Li Lu commented on YARN-5094:
-
bq. We can either populate the timestamp in
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296074#comment-15296074
]
Varun Saxena commented on YARN-5094:
You are correct. I think timestamp needs to be added for
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294486#comment-15294486
]
Li Lu commented on YARN-5094:
-
OK, seems like we missed something here: We use the incoming container event's
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286092#comment-15286092
]
Li Lu commented on YARN-5094:
-
Found same issue when working on the UI stuff. Let me take a look at it.
>
29 matches
Mail list logo
