[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293255#comment-15293255 ] Junping Du commented on YARN-5112: -- Thanks [~jianhe] for updating the patch. The left two checkstyle

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292603#comment-15292603 ] Hadoop QA commented on YARN-5112: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292523#comment-15292523 ] Junping Du commented on YARN-5112: -- bq. it's no straightforward to test the log message occurence, given

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292501#comment-15292501 ] Hadoop QA commented on YARN-5112: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292448#comment-15292448 ] Hadoop QA commented on YARN-5112: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292408#comment-15292408 ] Jian He commented on YARN-5112: --- Fixing the checkstyle, it's no straightforward to test the log message

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292378#comment-15292378 ] Junping Du commented on YARN-5112: -- Thanks Jian for the patch. Latest patch LGTM. However, can we add a

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292288#comment-15292288 ] Hadoop QA commented on YARN-5112: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292213#comment-15292213 ] Junping Du commented on YARN-5112: -- Thanks [~jianhe] for updating the patch. Remove

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291554#comment-15291554 ] Jian He commented on YARN-5112: --- Thanks for the review, Junping. Forgot to remove verifyAndCreateRemoteLogDir

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291486#comment-15291486 ] Hadoop QA commented on YARN-5112: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291026#comment-15291026 ] Junping Du commented on YARN-5112: -- Thanks [~jianhe] for reporting the issue and put a patch to fix it. I

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290567#comment-15290567 ] Hadoop QA commented on YARN-5112: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290232#comment-15290232 ] Hadoop QA commented on YARN-5112: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5112) Excessive log warnings on NM recovery

[ https://issues.apache.org/jira/browse/YARN-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290125#comment-15290125 ] Jian He commented on YARN-5112: --- move the check and init part to the common LogAggregationService init. >