[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422940#comment-15422940
]
Billie Rinaldi commented on YARN-5430:
--
+1, the patch looks good to me.
> Get container's ip and host
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422289#comment-15422289
]
Varun Vasudev commented on YARN-5430:
-
+1 for the latest patch. I'll commit it tomorrow if no one
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416566#comment-15416566
]
Jian He commented on YARN-5430:
---
The remaining warnings are not related to this patch.
> Get container's ip
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415543#comment-15415543
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415009#comment-15415009
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414833#comment-15414833
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414808#comment-15414808
]
Jian He commented on YARN-5430:
---
Varun, thanks for the review. I uploaded a new one.
> Get container's ip
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413786#comment-15413786
]
Varun Vasudev commented on YARN-5430:
-
Thanks for the patch [~jianhe].
1)
Can you please address the
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411871#comment-15411871
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411274#comment-15411274
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411234#comment-15411234
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408817#comment-15408817
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408799#comment-15408799
]
Jian He commented on YARN-5430:
---
Thanks for the review, Varun ! fixed other comments, uploaded a new patch
>
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408798#comment-15408798
]
Jian He commented on YARN-5430:
---
bq. Similarly we should change getIpAndHost and split them up into getIps
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406094#comment-15406094
]
Varun Vasudev commented on YARN-5430:
-
Thanks for the patch [~jianhe]!
1)
{code}
+ @Private
+
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405397#comment-15405397
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404142#comment-15404142
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393808#comment-15393808
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393572#comment-15393572
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393479#comment-15393479
]
Hadoop QA commented on YARN-5430:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
20 matches
Mail list logo
