[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149941#comment-16149941
]
Vrushali C commented on YARN-5547:
--
Thank you [~djp]!
> NMLeveldbStateStore should be more tolerant of
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149882#comment-16149882
]
Junping Du commented on YARN-5547:
--
Thanks [~vrushalic] for uploading the patch. branch-2.8 patch LGTM.
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149872#comment-16149872
]
Hadoop QA commented on YARN-5547:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149474#comment-16149474
]
Junping Du commented on YARN-5547:
--
Hi [~vrushalic], I am open to it if it can land on 2.8.2 today. Since
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149403#comment-16149403
]
Vrushali C commented on YARN-5547:
--
[~jlowe] [~djp]
Is it too late or is it still possible to get this in
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834403#comment-15834403
]
Hadoop QA commented on YARN-5547:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834338#comment-15834338
]
Ajith S commented on YARN-5547:
---
[~jlowe] thanks for the comments
I have updated the patch {without storing
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832050#comment-15832050
]
Jason Lowe commented on YARN-5547:
--
Thanks for updating the patch!
We're still storing a redundant killed
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831358#comment-15831358
]
Hadoop QA commented on YARN-5547:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831325#comment-15831325
]
Ajith S commented on YARN-5547:
---
Thanks for the detail explanation [~jlowe]
I have updated the patch with
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801788#comment-15801788
]
Jason Lowe commented on YARN-5547:
--
bq. for deleting the unknown keys, would it be ok to remove unknown
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800932#comment-15800932
]
Ajith S commented on YARN-5547:
---
Hi guys, sorry for delay. [~jlowe] thanks for your comments. You are right,
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800306#comment-15800306
]
Varun Vasudev commented on YARN-5547:
-
[~ajithshetty] - any updates on this?
> NMLeveldbStateStore
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665043#comment-15665043
]
Jason Lowe commented on YARN-5547:
--
Thanks for updating the patch!
Is there a good reason to store the
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15661426#comment-15661426
]
Naganarasimha G R commented on YARN-5547:
-
Thanks [~ajithshetty] for the patch, Seems like overall
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643617#comment-15643617
]
Hadoop QA commented on YARN-5547:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643557#comment-15643557
]
Varun Saxena commented on YARN-5547:
[~ajithshetty], I think we can raise another JIRA for adding a new
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643548#comment-15643548
]
Ajith S commented on YARN-5547:
---
Thanks [~Naganarasimha] for your comments. I have attached the latest patch
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620860#comment-15620860
]
Naganarasimha G R commented on YARN-5547:
-
Hi [~ajithshetty],
Patch does not seem to apply now,
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490550#comment-15490550
]
Naganarasimha G R commented on YARN-5547:
-
Thanks [~jlowe] for conclusion,
Agree having a table is
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490475#comment-15490475
]
Jason Lowe commented on YARN-5547:
--
To be clear, the skipping containers during recovery is _never_ the
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490429#comment-15490429
]
Ajith S commented on YARN-5547:
---
As per offline discussion with [~Naganarasimha Garla] and [~varun_saxena]
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490385#comment-15490385
]
Ajith S commented on YARN-5547:
---
So we have two approaches discussed here
1. Either skip container recovery -
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488333#comment-15488333
]
Jason Lowe commented on YARN-5547:
--
Yes, having the ability to recover unknown keys that cannot be ignored
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487715#comment-15487715
]
Chris Douglas commented on YARN-5547:
-
bq. Skipping the container entirely would be very bad. The NM
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478519#comment-15478519
]
Jason Lowe commented on YARN-5547:
--
Skipping the container entirely would be very bad. The NM would not
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478509#comment-15478509
]
Jason Lowe commented on YARN-5547:
--
That sounds like an excellent idea. If the old software could consult
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478512#comment-15478512
]
Arun Suresh commented on YARN-5547:
---
I just had an offline discussion with [~chris.douglas]. He was also
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478490#comment-15478490
]
Subru Krishnan commented on YARN-5547:
--
+1 on the need for this.
[~jlowe], you are bringing up good
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448813#comment-15448813
]
Hadoop QA commented on YARN-5547:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438921#comment-15438921
]
Jason Lowe commented on YARN-5547:
--
Thanks for the patch!
What I meant about the leak is a scenario like
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438766#comment-15438766
]
Ajith S commented on YARN-5547:
---
Hi [~jlowe]
I have attached the patch for handling the exception but i
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432153#comment-15432153
]
Ajith S commented on YARN-5547:
---
Thanks [~jlowe]. I would like to work on this. Incase you have already
[
https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430982#comment-15430982
]
Jason Lowe commented on YARN-5547:
--
Also see the backwards-compatibility discussions in YARN-3998 and
34 matches
Mail list logo
