[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114352#comment-16114352
]
Hadoop QA commented on YARN-5621:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114150#comment-16114150
]
Yang Wang commented on YARN-5621:
-
{code:title=LinuxContainerExecutor.java}
protected void
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524603#comment-15524603
]
Chris Douglas commented on YARN-5621:
-
That summary of work seems about right, thanks for putting it
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522339#comment-15522339
]
Jian He commented on YARN-5621:
---
I still have hesitation on this approach to spawn an additional process to
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510866#comment-15510866
]
Chris Douglas commented on YARN-5621:
-
bq. I think I understand your approach now, basically, [...]
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508689#comment-15508689
]
Jian He commented on YARN-5621:
---
Thanks for your explanation, some parts I'm missing:
bq. Both will start
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507320#comment-15507320
]
Chris Douglas commented on YARN-5621:
-
I think I see where the CL proposal was unclear.
It is an
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505601#comment-15505601
]
Jian He commented on YARN-5621:
---
My original thought is to create the symlinks right after localization
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504180#comment-15504180
]
Chris Douglas commented on YARN-5621:
-
bq. this approach will not work in rollback scenario, as in that
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502377#comment-15502377
]
Jian He commented on YARN-5621:
---
Hi [~chris.douglas], I had tried to implement with your approach. However,
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491452#comment-15491452
]
Chris Douglas commented on YARN-5621:
-
bq. This may be a viable approach, we need to change the
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482929#comment-15482929
]
Hadoop QA commented on YARN-5621:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480072#comment-15480072
]
Hadoop QA commented on YARN-5621:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479168#comment-15479168
]
Allen Wittenauer commented on YARN-5621:
I'll send you a note in private. ;)
> Support
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478543#comment-15478543
]
Chris Douglas commented on YARN-5621:
-
bq. FWIW, I'd love to see us drop the container launch script. I
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477967#comment-15477967
]
Allen Wittenauer commented on YARN-5621:
Actually, that reminds me where *is* the input
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477673#comment-15477673
]
Allen Wittenauer commented on YARN-5621:
Yup. Multiple invocations are easily worked around anyway
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477639#comment-15477639
]
Chris Douglas commented on YARN-5621:
-
bq. Because the passed in symlink path is an absolute path
Yes,
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475973#comment-15475973
]
Jian He commented on YARN-5621:
---
bq. the container launch script is pretty self contained, is mostly
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475871#comment-15475871
]
Allen Wittenauer commented on YARN-5621:
bq. Because it is a actually a script file and can also be
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475838#comment-15475838
]
Jian He commented on YARN-5621:
---
Hi Chris, thanks for chime in.
bq. Is the patch intended for another JIRA
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475198#comment-15475198
]
Chris Douglas commented on YARN-5621:
-
Is the patch intended for another JIRA, or is the title too
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474472#comment-15474472
]
Varun Vasudev commented on YARN-5621:
-
Thanks for the updated patch [~jianhe]. Couple of fixes for the
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474219#comment-15474219
]
Hadoop QA commented on YARN-5621:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474102#comment-15474102
]
Hadoop QA commented on YARN-5621:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474018#comment-15474018
]
Jian He commented on YARN-5621:
---
Thanks Varun for the review, addressed all comments.
bq. Can you explain
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472814#comment-15472814
]
Varun Vasudev commented on YARN-5621:
-
1)
{code}
+ File srcFile =
+
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470494#comment-15470494
]
Jian He commented on YARN-5621:
---
Because it is a actually a script file and can also be used for other
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470454#comment-15470454
]
Allen Wittenauer commented on YARN-5621:
Also, why is container-executor's symlink support actually
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469843#comment-15469843
]
Jian He commented on YARN-5621:
---
The warnings are not related.
> Support LinuxContainerExecutor to create
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469781#comment-15469781
]
Hadoop QA commented on YARN-5621:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469687#comment-15469687
]
Jian He commented on YARN-5621:
---
Thanks for the comments,
That was just to follow what it does in
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469632#comment-15469632
]
Allen Wittenauer commented on YARN-5621:
Any reason for using execlp instead of execl?
> Support
[
https://issues.apache.org/jira/browse/YARN-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469574#comment-15469574
]
Hadoop QA commented on YARN-5621:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
34 matches
Mail list logo
