[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526397#comment-15526397
]
Hadoop QA commented on YARN-5631:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522118#comment-15522118
]
Sunil G commented on YARN-5631:
---
Generally patch is looking fine except multiple indentation changes in
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522105#comment-15522105
]
Rohith Sharma K S commented on YARN-5631:
-
bq. Should we only fix added line?
Yes, otherwise diff
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502591#comment-15502591
]
Kai Sasaki commented on YARN-5631:
--
[~rohithsharma] Yes, I added only one line. But indentation level of
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502150#comment-15502150
]
Rohith Sharma K S commented on YARN-5631:
-
Thanks [~lewuathe] for the patch.. patch looks good, one
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500262#comment-15500262
]
Kai Sasaki commented on YARN-5631:
--
[~rohithsharma] I updated the patch. Test failures seems to be
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500225#comment-15500225
]
Hadoop QA commented on YARN-5631:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493403#comment-15493403
]
Hadoop QA commented on YARN-5631:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492551#comment-15492551
]
Hadoop QA commented on YARN-5631:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489248#comment-15489248
]
Rohith Sharma K S commented on YARN-5631:
-
[~lewuathe] could you please provide branch-2.8 patch?
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486864#comment-15486864
]
Hudson commented on YARN-5631:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10432 (See
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486833#comment-15486833
]
Rohith Sharma K S commented on YARN-5631:
-
committed to trunk/branch-2.. patch could not be applied
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483408#comment-15483408
]
Rohith Sharma K S commented on YARN-5631:
-
+1 LGTM, will commit it shortly
> Missing
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483276#comment-15483276
]
Sunil G commented on YARN-5631:
---
Looks good for me.
> Missing refreshClusterMaxPriority usage in rmadmin
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480985#comment-15480985
]
Kai Sasaki commented on YARN-5631:
--
[~sunilg] [~rohithsharma] Thanks for checking. I fixed checkstyle
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480776#comment-15480776
]
Hadoop QA commented on YARN-5631:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477396#comment-15477396
]
Sunil G commented on YARN-5631:
---
Thanks [~kaisasak] for pointing out.. Looks fine for me.
I think checkstyle
[
https://issues.apache.org/jira/browse/YARN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477136#comment-15477136
]
Hadoop QA commented on YARN-5631:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
18 matches
Mail list logo