[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146720#comment-16146720
]
Hudson commented on YARN-5715:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12271 (See
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614157#comment-15614157
]
Rohith Sharma K S commented on YARN-5715:
-
Thanks [~sjlee0] [~varun_saxena] [~gtCarrera9] for your
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613493#comment-15613493
]
Sangjin Lee commented on YARN-5715:
---
Filed YARN-5792 for the above.
> introduce entity prefix for return
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612940#comment-15612940
]
Sangjin Lee commented on YARN-5715:
---
[~rohithsharma], I'll take the liberty of modifying your patch to
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612857#comment-15612857
]
Sangjin Lee commented on YARN-5715:
---
This should be good to go if the above is addressed.
> introduce
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612752#comment-15612752
]
Varun Saxena commented on YARN-5715:
[~rohithsharma], I think this is good to go once you fix the
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596324#comment-15596324
]
Varun Saxena commented on YARN-5715:
Thanks [~rohithsharma] for the patch.
It looks good in general.
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595052#comment-15595052
]
Hadoop QA commented on YARN-5715:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593274#comment-15593274
]
Sangjin Lee commented on YARN-5715:
---
The jenkins appears to be unstable right now, and that might be why
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592457#comment-15592457
]
Varun Saxena commented on YARN-5715:
bq. it is for more than 7 parameters.
Sorry mixed it up with
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592348#comment-15592348
]
Sangjin Lee commented on YARN-5715:
---
bq. Regarding Li's comment, we should have a constant like
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592343#comment-15592343
]
Rohith Sharma K S commented on YARN-5715:
-
bq. Checkstyle is related.
it is for more than 7
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591602#comment-15591602
]
Varun Saxena commented on YARN-5715:
Thanks [~rohithsharma] for the patch. Patch looks fine to me.
Few
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591547#comment-15591547
]
Hadoop QA commented on YARN-5715:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591509#comment-15591509
]
Rohith Sharma K S commented on YARN-5715:
-
bq. I think it might be helpful to have a constant such
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587562#comment-15587562
]
Rohith Sharma K S commented on YARN-5715:
-
Sure, I will include in next patch.
> introduce entity
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587089#comment-15587089
]
Li Lu commented on YARN-5715:
-
I prefer the approach to provide an utility method to invert longs, and leave
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586951#comment-15586951
]
Sangjin Lee commented on YARN-5715:
---
Yes, that sounds like a good idea. [~rohithsharma], could you
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586491#comment-15586491
]
Varun Saxena commented on YARN-5715:
[~sjlee0], we have a class TimelineServiceHelper in
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586228#comment-15586228
]
Sangjin Lee commented on YARN-5715:
---
That sounds reasonable. I haven't checked, but don't we have a utils
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586168#comment-15586168
]
Varun Saxena commented on YARN-5715:
I think we can create a separate TimelineUtils class in
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586123#comment-15586123
]
Sangjin Lee commented on YARN-5715:
---
Thanks for bringing up the uid. Yes, I agree it is part of the uid.
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585839#comment-15585839
]
Varun Saxena commented on YARN-5715:
bq. I think we should discuss another point that does idPrefix
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585744#comment-15585744
]
Rohith Sharma K S commented on YARN-5715:
-
bq. What do others think?
As a user, I would expect my
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584596#comment-15584596
]
Varun Saxena commented on YARN-5715:
[~sjlee0]
bq. I think it’s fine either way, although I do think
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583379#comment-15583379
]
Sangjin Lee commented on YARN-5715:
---
Thanks for the patch [~rohithsharma]!
I think one thing we need to
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576474#comment-15576474
]
Varun Saxena commented on YARN-5715:
Changes related to TimelineReaderContext should be done in
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572451#comment-15572451
]
Varun Saxena commented on YARN-5715:
bq. Here, we can not use bytes as directory. I think need to
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571362#comment-15571362
]
Hadoop QA commented on YARN-5715:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570865#comment-15570865
]
Hadoop QA commented on YARN-5715:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569074#comment-15569074
]
Rohith Sharma K S commented on YARN-5715:
-
bq. As we are setting entity ID prefix to 0 and hence
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569043#comment-15569043
]
Varun Saxena commented on YARN-5715:
Sorry hadn't read the description. Read part will be done in
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569033#comment-15569033
]
Varun Saxena commented on YARN-5715:
Thanks [~rohithsharma] for the patch.
As we are setting entity ID
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568985#comment-15568985
]
Rohith Sharma K S commented on YARN-5715:
-
Pending :
# need up update same behavior for
[
https://issues.apache.org/jira/browse/YARN-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553462#comment-15553462
]
Sangjin Lee commented on YARN-5715:
---
During the call, I was thinking we might want to have a separate
35 matches
Mail list logo
