[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162241#comment-16162241
]
Hudson commented on YARN-6022:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12840 (See
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162202#comment-16162202
]
Hudson commented on YARN-6022:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12838 (See
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815715#comment-15815715
]
Wangda Tan commented on YARN-6022:
--
[~templedf],
Really appreciate your help for updating branch-2 patch.
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815257#comment-15815257
]
Daniel Templeton commented on YARN-6022:
[~leftnoteasy], since I did the branch-2 patch, do I need
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814265#comment-15814265
]
Hadoop QA commented on YARN-6022:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807848#comment-15807848
]
Hadoop QA commented on YARN-6022:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807829#comment-15807829
]
Hadoop QA commented on YARN-6022:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807806#comment-15807806
]
Hudson commented on YARN-6022:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11084 (See
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805663#comment-15805663
]
Hadoop QA commented on YARN-6022:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805534#comment-15805534
]
Daniel Templeton commented on YARN-6022:
Now that Jenkins is happy, I'll commit this afternoon.
>
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805526#comment-15805526
]
Hadoop QA commented on YARN-6022:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803311#comment-15803311
]
Hadoop QA commented on YARN-6022:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803103#comment-15803103
]
Wangda Tan commented on YARN-6022:
--
Thanks [~templedf]!
> Revert changes of AbstractResourceRequest
>
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802779#comment-15802779
]
Daniel Templeton commented on YARN-6022:
Bah, nevermind. The conflict is trivial. I'll take care
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802770#comment-15802770
]
Daniel Templeton commented on YARN-6022:
Sorry, [~leftnoteasy], there's a conflict now. Mind
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799573#comment-15799573
]
Daniel Templeton commented on YARN-6022:
Fair point. Fine, let's just get this in. +1 I'll
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799539#comment-15799539
]
Wangda Tan commented on YARN-6022:
--
[~templedf], I'm afraid not, since ResourceRequest doesn't have accept
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799053#comment-15799053
]
Daniel Templeton commented on YARN-6022:
The last patch looks clean. Looking at it, though,
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796904#comment-15796904
]
Hadoop QA commented on YARN-6022:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796729#comment-15796729
]
Daniel Templeton commented on YARN-6022:
Looks generally good. Thanks, [~leftnoteasy]. My only
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796608#comment-15796608
]
Wangda Tan commented on YARN-6022:
--
bq. Why wouldn't the user write the same thing as before:
Because it
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796601#comment-15796601
]
Daniel Templeton commented on YARN-6022:
{quote}According to API definition, user should write code
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796153#comment-15796153
]
Wangda Tan commented on YARN-6022:
--
[~kasha] / [~asuresh],
Missed your last comment somehow, apologize
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795677#comment-15795677
]
Arun Suresh commented on YARN-6022:
---
[~leftnoteasy], [~kasha], do you guys want to just move this to
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781255#comment-15781255
]
Junping Du commented on YARN-6022:
--
Remove 2.8 from target version given YARN-5774 was not actually in
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771737#comment-15771737
]
Karthik Kambatla commented on YARN-6022:
bq. For example, with this change, we need to make
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770909#comment-15770909
]
Wangda Tan commented on YARN-6022:
--
I would prefer to think about interface of SchedulerResourceRequest
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770883#comment-15770883
]
Arun Suresh commented on YARN-6022:
---
So, looks like the original class was created to unify Update
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770852#comment-15770852
]
Wangda Tan commented on YARN-6022:
--
bq. Have a SchedulerResourceRequest wrapper class that takes either a
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770843#comment-15770843
]
Arun Suresh commented on YARN-6022:
---
Hmmm... not sure why the inheritance is a problem..
But I agree,
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770806#comment-15770806
]
Wangda Tan commented on YARN-6022:
--
Probably mark it to private is not enough, because we should not make
[
https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770801#comment-15770801
]
Arun Suresh commented on YARN-6022:
---
Agree with [~leftnoteasy], we should also probably mark it as
32 matches
Mail list logo
