[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831338#comment-15831338
]
Hadoop QA commented on YARN-6031:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831288#comment-15831288
]
Sunil G commented on YARN-6031:
---
+1 for latest patch. Pending jenkins.
> Application recovery failed after
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831210#comment-15831210
]
Sunil G commented on YARN-6031:
---
Yes. It fell off from my radar.
However patch looks stale. Could you please
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831197#comment-15831197
]
Ying Zhang commented on YARN-6031:
--
Hi [~sunilg], would you please help to push this forward?:-)
>
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819959#comment-15819959
]
Ying Zhang commented on YARN-6031:
--
Failed test case () is known and tracked by YARN-5548.
> Application
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817878#comment-15817878
]
Hadoop QA commented on YARN-6031:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817767#comment-15817767
]
Sunil G commented on YARN-6031:
---
Patch generally looks fie for me. Will wait for jenkins to kick off.
Also
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817747#comment-15817747
]
Ying Zhang commented on YARN-6031:
--
Thanks [~sunilg]. Done. I was thinking that LOG.debug can do this
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817714#comment-15817714
]
Hadoop QA commented on YARN-6031:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817589#comment-15817589
]
Sunil G commented on YARN-6031:
---
Quick correction: Could u also pls added {{LOG.isDebugEnabled()}} before
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817555#comment-15817555
]
Ying Zhang commented on YARN-6031:
--
Thanks [~sunilg]. Modified the code and uploaded a new patch.
>
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817317#comment-15817317
]
Sunil G commented on YARN-6031:
---
Hi [~Ying Zhang]
When InvalidResourceRequestException is thrown from
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817265#comment-15817265
]
Ying Zhang commented on YARN-6031:
--
For findbugs error, it might be good to keep the null check in case
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817180#comment-15817180
]
Hadoop QA commented on YARN-6031:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817078#comment-15817078
]
Ying Zhang commented on YARN-6031:
--
Thanks very much [~sunilg] for the quick review. Comments addressed in
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815505#comment-15815505
]
Sunil G commented on YARN-6031:
---
Patch looks generally fine.
Few minor nits:
1.
{noformat}
String message =
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814625#comment-15814625
]
Hadoop QA commented on YARN-6031:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814463#comment-15814463
]
Ying Zhang commented on YARN-6031:
--
Thanks [~sunilg].
Uploaded a new patch with test case added.
>
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804114#comment-15804114
]
Sunil G commented on YARN-6031:
---
Since RMAppImpl handles APP_REJECTED event and we can move app from NEW to
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804106#comment-15804106
]
Ying Zhang commented on YARN-6031:
--
I've uploaded a new patch YARN-6031.002.patch with the suggested
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794582#comment-15794582
]
Ying Zhang commented on YARN-6031:
--
Oh I see, thanks. Will update the patch soon.
> Application recovery
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794578#comment-15794578
]
Sunil G commented on YARN-6031:
---
If we are not creating RMAppImpl object and starting the app transitions, we
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794548#comment-15794548
]
Ying Zhang commented on YARN-6031:
--
Hi [~leftnoteasy], I have a quick question here, if we just want to
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785845#comment-15785845
]
Wangda Tan commented on YARN-6031:
--
Thanks [~Ying Zhang] for updating patch, and thanks comments from
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784929#comment-15784929
]
Ying Zhang commented on YARN-6031:
--
It makes sense to me.
{quote}
If we skip and continue, then we will be
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784818#comment-15784818
]
Sunil G commented on YARN-6031:
---
I gave a second thought.
If we skip and continue, then we will be loosing
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784719#comment-15784719
]
Bibin A Chundatt commented on YARN-6031:
[~templedf]
{quote}
so that when using
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784349#comment-15784349
]
Ying Zhang commented on YARN-6031:
--
{quote}
Do you think we can make the log message a bit more explicit,
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784332#comment-15784332
]
Ying Zhang commented on YARN-6031:
--
So what's the next move? I'm a little confused. Are we going to
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784327#comment-15784327
]
Ying Zhang commented on YARN-6031:
--
{quote}
We could ignore/reset labels to default in resourcerequest
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783546#comment-15783546
]
Daniel Templeton commented on YARN-6031:
bq. IIUC ignore validation on recovery also should work.
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783397#comment-15783397
]
Bibin A Chundatt commented on YARN-6031:
As [~sunilg] mentioned earlier ignoring application could
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783232#comment-15783232
]
Daniel Templeton commented on YARN-6031:
I agree that {{-force-recovery}} could cause a significant
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783073#comment-15783073
]
Sunil G commented on YARN-6031:
---
Yes. Makes sense. This is more less a work for admin then. I am not so sure
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783025#comment-15783025
]
Daniel Templeton commented on YARN-6031:
bq. max_applications may hit and valid apps may get
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782995#comment-15782995
]
Sunil G commented on YARN-6031:
---
Yes [~templedf]. You are correct. We will end up having many flaky apps in
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782984#comment-15782984
]
Daniel Templeton commented on YARN-6031:
Yep, tests are needed. Love the long explanatory comment.
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782814#comment-15782814
]
Sunil G commented on YARN-6031:
---
Thanks [~Ying Zhang],
Overall approach makes sense to me. You are basically
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782566#comment-15782566
]
Ying Zhang commented on YARN-6031:
--
Uploaded a patch, which is based on [~leftnoteasy]'s comment on
[
https://issues.apache.org/jira/browse/YARN-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782197#comment-15782197
]
Sunil G commented on YARN-6031:
---
Thanks [~Ying Zhang] for raising this issue.
With the help of
40 matches
Mail list logo
