[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-10 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763263#comment-13763263 ] Zhijie Shen commented on YARN-609: -- Checked the three methods bellow. Though they're called

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-10 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763439#comment-13763439 ] Xuan Gong commented on YARN-609: Verified, they are used just as the setter.

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763473#comment-13763473 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-10 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763557#comment-13763557 ] Zhijie Shen commented on YARN-609: -- +1 LGMT Fix synchronization issues in

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1376#comment-1376 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-08 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761554#comment-13761554 ] Zhijie Shen commented on YARN-609: -- The patch looks good to me, but would you please

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761574#comment-13761574 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760431#comment-13760431 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760487#comment-13760487 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756849#comment-13756849 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-03 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756819#comment-13756819 ] Xuan Gong commented on YARN-609: Do the synchronized set and get on the apis which take in

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757126#comment-13757126 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-09-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757030#comment-13757030 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-08-27 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751501#comment-13751501 ] Zhijie Shen commented on YARN-609: -- IMHO, the straightforward fix is to add synchronized

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-07-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720351#comment-13720351 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-609) Fix synchronization issues in APIs which take in lists

2013-07-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715889#comment-13715889 ] Hadoop QA commented on YARN-609: {color:red}-1 overall{color}. Here are the results of