[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975226#comment-15975226 ] Hudson commented on YARN-6438: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1160

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-19 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975134#comment-15975134 ] Daniel Templeton commented on YARN-6438: +1 LGTM > Code can be improved in Contain

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969631#comment-15969631 ] Hadoop QA commented on YARN-6438: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-14 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969569#comment-15969569 ] Miklos Szegedi commented on YARN-6438: -- Good point [~templedf]. I meant to keep both,

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966771#comment-15966771 ] Daniel Templeton commented on YARN-6438: Thanks for the patch, [~miklos.szeg...@clo

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-05 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957488#comment-15957488 ] Miklos Szegedi commented on YARN-6438: -- Thank you, [~yufeigu]. > Code can be improved

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-05 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957408#comment-15957408 ] Yufei Gu commented on YARN-6438: +1 (non-binding) > Code can be improved in ContainersMoni

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957335#comment-15957335 ] Hadoop QA commented on YARN-6438: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-05 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957278#comment-15957278 ] Yufei Gu commented on YARN-6438: Patch looks good. Only one nit, this comments should be re

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-04 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956153#comment-15956153 ] Yufei Gu commented on YARN-6438: Thanks for the patch, [~miklos.szeg...@cloudera.com]! Some

[jira] [Commented] (YARN-6438) Code can be improved in ContainersMonitorImpl.java

2017-04-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955939#comment-15955939 ] Hadoop QA commented on YARN-6438: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||