[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-08 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506151#comment-16506151 ] Haibo Chen commented on YARN-6677: -- Thanks for the review, [~szegedim]! > Preempt opport

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505523#comment-16505523 ] Hudson commented on YARN-6677: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #143

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-07 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505510#comment-16505510 ] Miklos Szegedi commented on YARN-6677: -- Committed to trunk as well per request of [~h

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-07 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505177#comment-16505177 ] Miklos Szegedi commented on YARN-6677: -- +1 LGTM. > Preempt opportunistic containers

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-07 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504353#comment-16504353 ] genericqa commented on YARN-6677: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-06 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504288#comment-16504288 ] Haibo Chen commented on YARN-6677: -- Updated the patch again to address the new findbugs i

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-06 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504253#comment-16504253 ] genericqa commented on YARN-6677: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-06 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504204#comment-16504204 ] Haibo Chen commented on YARN-6677: -- Yes, attached a new patch to address the findbugs war

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-06 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504060#comment-16504060 ] Miklos Szegedi commented on YARN-6677: -- [~haibochen], could you address the findbugs?

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-04 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501123#comment-16501123 ] genericqa commented on YARN-6677: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-04 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501039#comment-16501039 ] Haibo Chen commented on YARN-6677: -- Updated the patch to address all but one checkstyle i

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-04 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501010#comment-16501010 ] Haibo Chen commented on YARN-6677: -- I think the findbugs warning is bonus because the wra

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-06-04 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500980#comment-16500980 ] genericqa commented on YARN-6677: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-05-31 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496950#comment-16496950 ] Miklos Szegedi commented on YARN-6677: -- Thanks, for the update [~haibochen]. {code:ja

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-05-31 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496748#comment-16496748 ] genericqa commented on YARN-6677: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-05-31 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496638#comment-16496638 ] Haibo Chen commented on YARN-6677: -- I updated the patch without addressing the getCGroups

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-05-29 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494614#comment-16494614 ] Miklos Szegedi commented on YARN-6677: -- Indeed. How about a comparator with a conditi

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-05-29 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493926#comment-16493926 ] Haibo Chen commented on YARN-6677: -- Thanks [~miklos.szeg...@cloudera.com] for the comment

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-05-28 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493085#comment-16493085 ] Miklos Szegedi commented on YARN-6677: -- Thank you, [~haibochen] for the patch. {code:

[jira] [Commented] (YARN-6677) Preempt opportunistic containers when root container cgroup goes over memory limit

2018-05-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488291#comment-16488291 ] genericqa commented on YARN-6677: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||