[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086624#comment-16086624 ] daemon commented on YARN-6769: -- [~yufeigu], Thanks yufei. I really name is zhouyunfan. Thank you so mush for

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086052#comment-16086052 ] Yufei Gu commented on YARN-6769: Hi [~daemon], we usually put contributor's name in git logs, something

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086013#comment-16086013 ] Yufei Gu commented on YARN-6769: LGTM. +1. > Put the no demand queue after the most in

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085530#comment-16085530 ] daemon commented on YARN-6769: -- [~yufeigu] hi, yufei. Is there any other problems in my new patch? > Put the

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085424#comment-16085424 ] Hadoop QA commented on YARN-6769: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084558#comment-16084558 ] Yufei Gu commented on YARN-6769: Thanks for the new patch. Some nits: # Can we change Java doc to

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081923#comment-16081923 ] daemon commented on YARN-6769: -- [~yufeigu] Thanks yufei. You are right, I have already fix those problems. >

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081764#comment-16081764 ] Hadoop QA commented on YARN-6769: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081450#comment-16081450 ] Yufei Gu commented on YARN-6769: The patch looks good to me generally. Some thoughts: # The logic in

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079869#comment-16079869 ] daemon commented on YARN-6769: -- [~templedf] hi, Daniel. Can you help review my code? Pretty thanks! > Put

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079666#comment-16079666 ] Hadoop QA commented on YARN-6769: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079643#comment-16079643 ] daemon commented on YARN-6769: -- [~hadoopqa] I am sorry for my break the test, so I fix it and upload a new

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079481#comment-16079481 ] Hadoop QA commented on YARN-6769: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079453#comment-16079453 ] daemon commented on YARN-6769: -- [~yufei] Thanks yufei. I have already upload my patch file, what is the next I

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078430#comment-16078430 ] Yufei Gu commented on YARN-6769: Thanks [~daemon] for working on this. [~templedf] has added you as a

[jira] [Commented] (YARN-6769) Put the no demand queue after the most in FairSharePolicy#compare

[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077525#comment-16077525 ] daemon commented on YARN-6769: -- diff --git