[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146032#comment-16146032 ] Jason Lowe commented on YARN-6876: -- Previously the IOUtils.cleanup calls were passed a logger that would

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145895#comment-16145895 ] Xuan Gong commented on YARN-6876: - [~jlowe] bq. Sorry for the late comment, but I was just looking at the

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144402#comment-16144402 ] Jason Lowe commented on YARN-6876: -- Sorry for the late comment, but I was just looking at the code in

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140690#comment-16140690 ] Hudson commented on YARN-6876: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12238 (See

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139376#comment-16139376 ] Junping Du commented on YARN-6876: -- 006 patch LGTM. The findbugs issue and unit test failure is not

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139307#comment-16139307 ] Hadoop QA commented on YARN-6876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139157#comment-16139157 ] Xuan Gong commented on YARN-6876: - Thanks for the review. [~djp] bq. LogAggregationFileController.java is

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139039#comment-16139039 ] Junping Du commented on YARN-6876: -- Thanks [~xgong] for updating the patch. The latest patch looks much

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137577#comment-16137577 ] Hadoop QA commented on YARN-6876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137386#comment-16137386 ] Xuan Gong commented on YARN-6876: - Thanks for the review. [~djp] Uploaded a new patch to address all your

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135926#comment-16135926 ] Junping Du commented on YARN-6876: -- Thanks [~xgong] for uploading the patch. Sorry for coming late on

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129668#comment-16129668 ] Hadoop QA commented on YARN-6876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110024#comment-16110024 ] Hadoop QA commented on YARN-6876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109423#comment-16109423 ] Hadoop QA commented on YARN-6876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108201#comment-16108201 ] Hadoop QA commented on YARN-6876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103842#comment-16103842 ] Hadoop QA commented on YARN-6876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6876) Create an abstract log writer for extendability

[ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102341#comment-16102341 ] Hadoop QA commented on YARN-6876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||