[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-17 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441108#comment-16441108 ] Eric Badger commented on YARN-7189: --- Thanks for the review and commit, [~jlowe]! > Container-executor

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439556#comment-16439556 ] Jason Lowe commented on YARN-7189: -- Thanks for updating the patch! +1 lgtm. I'll commit this later today

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438003#comment-16438003 ] genericqa commented on YARN-7189: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437990#comment-16437990 ] genericqa commented on YARN-7189: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-13 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437908#comment-16437908 ] Eric Badger commented on YARN-7189: --- Sorry for the patch overload. Found a few nits right after I put up

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-13 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437850#comment-16437850 ] Eric Badger commented on YARN-7189: --- Thanks for the review, [~jlowe]! Fixed up the patch to use the

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436358#comment-16436358 ] Jason Lowe commented on YARN-7189: -- Thanks for updating the patch! I agree this looks difficult to unit

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-12 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435835#comment-16435835 ] Eric Badger commented on YARN-7189: --- The TestDockerContainerRuntime failures are unrelated to this patch

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434650#comment-16434650 ] genericqa commented on YARN-7189: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-11 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434466#comment-16434466 ] Eric Badger commented on YARN-7189: --- [~jlowe], new patch cleans some things up. Looping over pclose()

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434063#comment-16434063 ] Jason Lowe commented on YARN-7189: -- Thanks for the patch! The {{i < 5}} check is extraneous and would

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434057#comment-16434057 ] genericqa commented on YARN-7189: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-11 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433936#comment-16433936 ] Eric Badger commented on YARN-7189: --- Attaching patch with correct naming convention to hopefully get

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433932#comment-16433932 ] genericqa commented on YARN-7189: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-10 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433137#comment-16433137 ] Eric Badger commented on YARN-7189: --- Attaching first patch to fix this issue. There is a race in the