[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204032#comment-16204032 ] Hadoop QA commented on YARN-7270: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204024#comment-16204024 ] Daniel Templeton commented on YARN-7270: LGTM. On the test class name, there's certainly lots of

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203868#comment-16203868 ] Sunil G commented on YARN-7270: --- Yes. Correct. Fine from end as well. Thanks. > Resource#getVirtualCores()

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203847#comment-16203847 ] Wangda Tan commented on YARN-7270: -- [~sunilg], bq. please use res.getMemorySize instead of res.getMemory

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203845#comment-16203845 ] Yufei Gu commented on YARN-7270: It is related. This patch intends to test {{getMemory()}} instead of

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203727#comment-16203727 ] Sunil G commented on YARN-7270: --- javac warning is related. In {{TestResourcePBImpl}}, please use

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203719#comment-16203719 ] Hadoop QA commented on YARN-7270: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203144#comment-16203144 ] Sunil G commented on YARN-7270: --- I am good with latest patch. Will wait for jenkins. >

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202937#comment-16202937 ] Hadoop QA commented on YARN-7270: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202858#comment-16202858 ] Yufei Gu commented on YARN-7270: Uploaded patch v3 since class {{TestResource}} is missing in patch v2.

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199290#comment-16199290 ] Yufei Gu commented on YARN-7270: The javac warning is fine since it is the test code calling the deprecated

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199226#comment-16199226 ] Hadoop QA commented on YARN-7270: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191277#comment-16191277 ] Daniel Templeton commented on YARN-7270: Thanks, [~yufeigu]. My comments: # You're missing a space

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189067#comment-16189067 ] Yufei Gu commented on YARN-7270: Thanks [~sunilg] for the review. # I'm not sure either, but I think if we

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186924#comment-16186924 ] Sunil G commented on YARN-7270: --- Thanks [~yufeigu]. Approach makes sense to me. I am not very sure about the

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186274#comment-16186274 ] Hadoop QA commented on YARN-7270: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7270) Resource#getVirtualCores() does unsafe casting from long to int.

[ https://issues.apache.org/jira/browse/YARN-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186151#comment-16186151 ] Yufei Gu commented on YARN-7270: The patch is straightforward. [~wangda]/[~templedf], could you take a