[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407042#comment-16407042
]
genericqa commented on YARN-7316:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226937#comment-16226937
]
lovekesh bansal commented on YARN-7316:
---
I think passing Resource calculator as an argument should
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226802#comment-16226802
]
Sunil G commented on YARN-7316:
---
I understood your point well. However post your suggested approach, we will
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226244#comment-16226244
]
Daniel Templeton commented on YARN-7316:
I had been planning to post a JIRA to remove the methods
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226124#comment-16226124
]
Sunil G commented on YARN-7316:
---
I think it was mainly because of a readability and to go with a common
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225778#comment-16225778
]
Daniel Templeton commented on YARN-7316:
I've actually been actively doing the opposite. It seems
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218450#comment-16218450
]
lovekesh bansal commented on YARN-7316:
---
[~sunilg] Yes, It is cleaned up everywhere and Resources.api
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218434#comment-16218434
]
lovekesh bansal commented on YARN-7316:
---
[~sunilg] Thanks Sunil. Yes all the usage was cleaned up
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218317#comment-16218317
]
Sunil G commented on YARN-7316:
---
Thanks [~lovekesh.bansal].
I am in line with your approach. Could you please
[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200388#comment-16200388
]
Hadoop QA commented on YARN-7316:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
10 matches
Mail list logo