[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472839#comment-16472839
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Thank you for the great reviews and commit.
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472822#comment-16472822
]
Hudson commented on YARN-7654:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14180 (See
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472814#comment-16472814
]
Jason Lowe commented on YARN-7654:
--
Thanks for updating the patch! The unit test failure does not appear
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472806#comment-16472806
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472778#comment-16472778
]
Eric Yang commented on YARN-7654:
-
[~jlowe] All 5 scenarios passed with my local kerberos enabled cluster
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472661#comment-16472661
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Patch 24 fixed the issues above. I still need time to test all
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472597#comment-16472597
]
Jason Lowe commented on YARN-7654:
--
Thanks for updating the patch!
AbstractLauncher still has a
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472591#comment-16472591
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472407#comment-16472407
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Patch 23 includes all your suggestions.
> Support ENTRY_POINT
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472318#comment-16472318
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Thanks for the reply. Some answers:
{quote}
In
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472209#comment-16472209
]
Jason Lowe commented on YARN-7654:
--
Thanks for updating the patch!
This previous comment appears to have
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471443#comment-16471443
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471387#comment-16471387
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Patch 22 contains all requested changes except refactoring code
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471073#comment-16471073
]
Eric Yang commented on YARN-7654:
-
[~jlowe] I am struggling withe the following problems:
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470427#comment-16470427
]
Jason Lowe commented on YARN-7654:
--
bq. The patch writes .env file in the same nmPrivate directory as .cmd
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469823#comment-16469823
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Thank you for the review, the styling improvement will be
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469613#comment-16469613
]
Jason Lowe commented on YARN-7654:
--
In the interest in trying to get this into 3.1, I'm OK with going with
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469061#comment-16469061
]
Eric Yang commented on YARN-7654:
-
[~jlowe] [~Jim_Brennan] I misread the last message in the discussion
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468949#comment-16468949
]
Jim Brennan commented on YARN-7654:
---
{quote}docker logs does not seem to separate out stdout from stderr.
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468907#comment-16468907
]
Jason Lowe commented on YARN-7654:
--
{{docker logs -f}} does what we want (at least as of Docker 1.13.1
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468251#comment-16468251
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468111#comment-16468111
]
Eric Yang commented on YARN-7654:
-
[~jlowe] {quote}I'll try to find time to take a closer look at this
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467977#comment-16467977
]
Jason Lowe commented on YARN-7654:
--
I'll try to find time to take a closer look at this patch tomorrow,
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466258#comment-16466258
]
Eric Yang commented on YARN-7654:
-
Rebased patch 20 to based on YARN-8207 patch 007.
> Support ENTRY_POINT
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460353#comment-16460353
]
Eric Yang commented on YARN-7654:
-
Rebased patch to based on YARN-8207 patch 5.
> Support ENTRY_POINT for
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453454#comment-16453454
]
Eric Yang commented on YARN-7654:
-
[~jlowe] {quote}By default this is true, but it is trivial to use them
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453344#comment-16453344
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Patch 18 contains only ENTRY_POINT support code. I cancel the
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453247#comment-16453247
]
Eric Yang commented on YARN-7654:
-
[~jlowe] I filed YARN-8207 for moving execv changes to that JIRA.
>
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453119#comment-16453119
]
Jason Lowe commented on YARN-7654:
--
I am not proposing to postpone the execv changes, rather to break up
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453079#comment-16453079
]
Eric Yang commented on YARN-7654:
-
[~jlowe] {quote}
My apologies for the delay. I hope to get some time to
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452963#comment-16452963
]
Jason Lowe commented on YARN-7654:
--
My apologies for the delay. I hope to get some time to look at this
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452508#comment-16452508
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Can you review the latest patch to see if it addressed all your
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451687#comment-16451687
]
genericqa commented on YARN-7654:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451531#comment-16451531
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450105#comment-16450105
]
Eric Yang commented on YARN-7654:
-
Patch 17 fixed checkstyle and unused variable issue.
> Support
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449113#comment-16449113
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448984#comment-16448984
]
Eric Yang commented on YARN-7654:
-
Patch 16 is changed to support env-file only without -e parameters. The
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446895#comment-16446895
]
Eric Yang commented on YARN-7654:
-
[~jlowe][~ebadger][~Jim_Brennan][~shaneku...@gmail.com] Thank you all
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446801#comment-16446801
]
Shane Kumpf commented on YARN-7654:
---
Thanks for the updated patches, [~eyang]. I'm still going through my
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446439#comment-16446439
]
Eric Yang commented on YARN-7654:
-
{quote}For example, you say that a customer may want to have docker be
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446405#comment-16446405
]
Jim Brennan commented on YARN-7654:
---
I'm not going to repeat all of the arguments, but I agree with
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446394#comment-16446394
]
Eric Badger commented on YARN-7654:
---
{quote}With docker, container-executor doesn't drop privileges to
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446205#comment-16446205
]
Eric Yang commented on YARN-7654:
-
[~ebadger]
{quote}
I'm confused by this point. Can you explain
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446109#comment-16446109
]
Eric Badger commented on YARN-7654:
---
bq. Possible limitation when docker run user != YARN user, nmPrivate
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445990#comment-16445990
]
Eric Yang commented on YARN-7654:
-
[~jlowe] {quote}This is not a pro, it's a con. Users will pass secrets
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445904#comment-16445904
]
Jason Lowe commented on YARN-7654:
--
{quote}No additional file to clean up, environment variables can be
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443305#comment-16443305
]
Eric Yang commented on YARN-7654:
-
For following up on today's meet up discussion:
Proposal 1: Environment
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441738#comment-16441738
]
genericqa commented on YARN-7654:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441711#comment-16441711
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441610#comment-16441610
]
Eric Yang commented on YARN-7654:
-
Patch 14 fixed white space error. Patch 13 seems to have caught between
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440218#comment-16440218
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440187#comment-16440187
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440120#comment-16440120
]
Eric Yang commented on YARN-7654:
-
Patch 12 rebased to current trunk, and removed some unnecessary changes.
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436511#comment-16436511
]
Eric Yang commented on YARN-7654:
-
Patch 11 fixed checkstyle problems.
> Support ENTRY_POINT for docker
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436508#comment-16436508
]
Eric Yang commented on YARN-7654:
-
The failed unit test is tracked in YARN-7700, and not related to this
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434686#comment-16434686
]
genericqa commented on YARN-7654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434527#comment-16434527
]
Eric Yang commented on YARN-7654:
-
Rebase patch 10 to current trunk after YARN-7221 and YARN-7973 changes.
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424782#comment-16424782
]
Eric Yang commented on YARN-7654:
-
Rebased patch to changes based on YARN-7221 patch 16.
> Support
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424238#comment-16424238
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Patch 008 fixed API leakages, and code style problems that you
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422954#comment-16422954
]
Eric Yang commented on YARN-7654:
-
[~jlowe] launch-container.sh doesn't exist in entry_point mode. Node
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422893#comment-16422893
]
Jason Lowe commented on YARN-7654:
--
We can place the debugging in the already existing launch-container.sh
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422826#comment-16422826
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Env-file design would work better when user to supply the
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422531#comment-16422531
]
Jason Lowe commented on YARN-7654:
--
It does not make sense to me to support both options. It
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420991#comment-16420991
]
Eric Yang commented on YARN-7654:
-
[~jlowe]
{quote}
Why would be be specifying both arguments? All of the
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420736#comment-16420736
]
Jason Lowe commented on YARN-7654:
--
{quote}On Mac, it doesn't function the same for key value pair that
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420659#comment-16420659
]
Eric Yang commented on YARN-7654:
-
[~jlowe] {quote}
I strongly disagree here. It is much more dangerous try
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420623#comment-16420623
]
Jason Lowe commented on YARN-7654:
--
{quote}The cmd file section based approach is the best option in my
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420054#comment-16420054
]
Eric Yang commented on YARN-7654:
-
[~jlowe]
{quote}
Why does add_param_to_command_if_allowed bother to
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1642#comment-1642
]
Eric Yang commented on YARN-7654:
-
[~jlowe] {quote}
In the following code the parent frees memory that the
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419920#comment-16419920
]
Eric Yang commented on YARN-7654:
-
[~jlowe] . Thank you for the feedback. The cmd file section based
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419835#comment-16419835
]
Jason Lowe commented on YARN-7654:
--
Thanks for updating the patch!
{quote}Is this the proposed approach?
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419382#comment-16419382
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Patch 007 has been updated to use section to list environment
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418246#comment-16418246
]
Eric Yang commented on YARN-7654:
-
[~jlowe] The patch has been rebased to depend on YARN-7221 patch 12.
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410627#comment-16410627
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Patch 005 requires YARN-7221 patch 10. This patch has been
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409923#comment-16409923
]
Eric Yang commented on YARN-7654:
-
[~jlowe] YARN-6830 appears to focus on Java side of serialization. It
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409856#comment-16409856
]
Jason Lowe commented on YARN-7654:
--
bq. Can you share how spark does tokenizer for environment variables
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408784#comment-16408784
]
Eric Yang commented on YARN-7654:
-
[~jlowe]
{quote} Why are we avoiding sanitizeEnv in the entry point
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408761#comment-16408761
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Can you share how spark does tokenizer for environment
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408751#comment-16408751
]
Eric Yang commented on YARN-7654:
-
{quote}
buff_len is an argument that keeps getting passed around but
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408735#comment-16408735
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Thank you for the review, the patch was based on:
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408637#comment-16408637
]
Jason Lowe commented on YARN-7654:
--
What is the base for this patch? It doesn't apply directly, and I
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405625#comment-16405625
]
Eric Yang commented on YARN-7654:
-
Patch 004 addresses the following:
- Ensure container environment
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402098#comment-16402098
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Yes, you are right patch 001 doesn't handle shell expansion,
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401973#comment-16401973
]
Jason Lowe commented on YARN-7654:
--
bq. As you can see the struggle with flipping code for execv, this is
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401357#comment-16401357
]
Eric Yang commented on YARN-7654:
-
- Fixed the concurrency issue, and added exit code check. The new execv
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401192#comment-16401192
]
Eric Yang commented on YARN-7654:
-
[~jlowe] Thank you for the review. This patch requires YARN-7221 to
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400676#comment-16400676
]
Jason Lowe commented on YARN-7654:
--
Thanks for the patch! Switching the code to execv docker instead of
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399772#comment-16399772
]
Eric Yang commented on YARN-7654:
-
[~ebadger] [~jlowe] [~shaneku...@gmail.com] This is a early patch using
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389883#comment-16389883
]
Eric Yang commented on YARN-7654:
-
Hi [~ebadger] [~billie.rinaldi] [~shaneku...@gmail.com] Here is an early
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384394#comment-16384394
]
Eric Yang commented on YARN-7654:
-
[~ebadger] I agree with your analysis. [~Jim_Brennan] Sorry, I might
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384303#comment-16384303
]
Eric Badger commented on YARN-7654:
---
bq. The parent layer (container-executor) provide the same
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384187#comment-16384187
]
Eric Yang commented on YARN-7654:
-
[~Jim_Brennan] Yes, this is partially true. The actual behavior
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384032#comment-16384032
]
Jim Brennan commented on YARN-7654:
---
{quote}
1. Dockerfile describes ENV variables, they are the default
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383975#comment-16383975
]
Eric Yang commented on YARN-7654:
-
[~shaneku...@gmail.com] Sounds good, the entry point will be activated
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383972#comment-16383972
]
Eric Yang commented on YARN-7654:
-
[~Jim_Brennan] [~ebadger] The answers are not straight forward, and here
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383939#comment-16383939
]
Jim Brennan commented on YARN-7654:
---
{quote}But how do you differentiate between user-defined variables
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383781#comment-16383781
]
Eric Badger commented on YARN-7654:
---
bq. I plan to retain the current behavior. If USE_ENTRY_POINT is
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383563#comment-16383563
]
Shane Kumpf commented on YARN-7654:
---
{quote}The second mode will launch container and bind-mount HDFS via
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382976#comment-16382976
]
Eric Yang commented on YARN-7654:
-
[~ebadger]
{quote}
Don't we need the workdir to be defined in the image?
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382590#comment-16382590
]
Eric Badger commented on YARN-7654:
---
bq. Will we eliminate setting the workdir in this model and leave
1 - 100 of 104 matches
Mail list logo
