[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172642#comment-17172642
]
Jim Brennan commented on YARN-7677:
---
Thanks [~ebadger]!
> Docker image cannot set HADOOP_CONF_DIR
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171852#comment-17171852
]
Hadoop QA commented on YARN-7677:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170951#comment-17170951
]
Eric Badger commented on YARN-7677:
---
Thanks, [~aajisaka]!
Cancelling and resubmitting the patch to
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170505#comment-17170505
]
Akira Ajisaka commented on YARN-7677:
-
Cherry-picked HADOOP-14056 into branch-2.10 to fix this error.
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170500#comment-17170500
]
Akira Ajisaka commented on YARN-7677:
-
This failure occurs in PreCommit--Build jobs because now
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170499#comment-17170499
]
Akira Ajisaka commented on YARN-7677:
-
Thanks [~ebadger] for pinging me. Sorry, HADOOP-17091 is
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170464#comment-17170464
]
Eric Badger commented on YARN-7677:
---
[~Jim_Brennan], I'm +1 on this patch. I'll give a day for others to
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170463#comment-17170463
]
Eric Badger commented on YARN-7677:
---
I think https://issues.apache.org/jira/browse/HADOOP-17091 is
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170449#comment-17170449
]
Jim Brennan commented on YARN-7677:
---
The TestFederationInterceptor unit test failure is unrelated.
I
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170448#comment-17170448
]
Hadoop QA commented on YARN-7677:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170403#comment-17170403
]
Jim Brennan commented on YARN-7677:
---
I submitted patch branch-2.10-002 to fix most of the checkstyle
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170225#comment-17170225
]
Hadoop QA commented on YARN-7677:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389707#comment-16389707
]
Hudson commented on YARN-7677:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13786 (See
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389562#comment-16389562
]
Shane Kumpf commented on YARN-7677:
---
+1 (non-binding) from me as well. I ran my usual suite of tests with
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388772#comment-16388772
]
Eric Yang commented on YARN-7677:
-
+1 works on my system.
> Docker image cannot set HADOOP_CONF_DIR
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388632#comment-16388632
]
Jason Lowe commented on YARN-7677:
--
Thanks for updating the patch!
+1 lgtm. I'll commit this tomorrow if
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381129#comment-16381129
]
Jim Brennan commented on YARN-7677:
---
Check-style issues are expected, as noted above.
Unit test failure
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381126#comment-16381126
]
genericqa commented on YARN-7677:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381033#comment-16381033
]
Jim Brennan commented on YARN-7677:
---
Uploaded another patch that fixes the extra import reported by
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380980#comment-16380980
]
genericqa commented on YARN-7677:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380382#comment-16380382
]
Jim Brennan commented on YARN-7677:
---
[~eyang] the user cannot override the variables that are explicitly
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379501#comment-16379501
]
Eric Yang commented on YARN-7677:
-
Can user override NM_HOST, NM_PORT etc? I think it would be safer when
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379347#comment-16379347
]
Jim Brennan commented on YARN-7677:
---
{quote}What variables are set explicitly by NM?{quote}
Primarily
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379289#comment-16379289
]
Eric Yang commented on YARN-7677:
-
[~Jim_Brennan] What variables are set explicitly by NM?
> Docker image
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377034#comment-16377034
]
Jim Brennan commented on YARN-7677:
---
Now that YARN-5714 has been resolved, we have two options for
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369205#comment-16369205
]
Jim Brennan commented on YARN-7677:
---
Agreed. Without this patch, the ordering of variables in the
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369188#comment-16369188
]
Hudson commented on YARN-7677:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13681 (See
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368788#comment-16368788
]
Rohith Sharma K S commented on YARN-7677:
-
bq. I think {{HADOOP_MAPRED_HOME}} should occur before
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368458#comment-16368458
]
Rohith Sharma K S commented on YARN-7677:
-
This patch causing MR job launch failure! See
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366420#comment-16366420
]
Hudson commented on YARN-7677:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13667 (See
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365736#comment-16365736
]
Jason Lowe commented on YARN-7677:
--
That makes sense. Agreed it is probably safer to leave the CLASSPATH
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365721#comment-16365721
]
Jim Brennan commented on YARN-7677:
---
[~jlowe], do you agree about the CLASSPATH for windows? Let me know
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364945#comment-16364945
]
Jim Brennan commented on YARN-7677:
---
{quote}I noticed that sanitizeWindowsEnv no longer adds CLASSPATH to
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364890#comment-16364890
]
Jason Lowe commented on YARN-7677:
--
Thanks for updating the patch! Overall looks good, but I noticed that
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364778#comment-16364778
]
Jim Brennan commented on YARN-7677:
---
The remaining check-style issue is for adding an 8th parameter to
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364771#comment-16364771
]
genericqa commented on YARN-7677:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364652#comment-16364652
]
Jim Brennan commented on YARN-7677:
---
Uploaded another patch with updates based on [~jlowe]'s review.
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363006#comment-16363006
]
Jim Brennan commented on YARN-7677:
---
Thanks for the review! I will address these issues and put up a new
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362921#comment-16362921
]
Jason Lowe commented on YARN-7677:
--
Thanks for updating the patch! Looks good overall, just a few nits:
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362696#comment-16362696
]
Jim Brennan commented on YARN-7677:
---
I believe these are intermittent failures:
{noformat}
ERROR]
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362603#comment-16362603
]
genericqa commented on YARN-7677:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362445#comment-16362445
]
Jim Brennan commented on YARN-7677:
---
I submitted a new patch that addresses some of the style-check
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361510#comment-16361510
]
genericqa commented on YARN-7677:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361418#comment-16361418
]
Jim Brennan commented on YARN-7677:
---
I've put up another patch for this that addresses the ordering
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350500#comment-16350500
]
Jim Brennan commented on YARN-7677:
---
Thanks everyone! I will work on a new patch using this approach.
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350368#comment-16350368
]
Billie Rinaldi commented on YARN-7677:
--
That sounds like a good approach, NM vars followed by
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350353#comment-16350353
]
Jason Lowe commented on YARN-7677:
--
I realize now that the theoretical example cannot work in practice.
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349465#comment-16349465
]
Eric Yang commented on YARN-7677:
-
[~jlowe] I agree with [~billie.rinaldi] and YARN-5714 approach. The
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349437#comment-16349437
]
Jason Lowe commented on YARN-7677:
--
True, but that assumes the user even knows what the path is. The
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349449#comment-16349449
]
Billie Rinaldi commented on YARN-7677:
--
They'd have to be told the available versions by the admins,
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349435#comment-16349435
]
Billie Rinaldi commented on YARN-7677:
--
It would be much more straightforward for the user to set
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349420#comment-16349420
]
Jason Lowe commented on YARN-7677:
--
bq. the primary use case is AM-defined vars being able to reference
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349338#comment-16349338
]
Shane Kumpf commented on YARN-7677:
---
Thanks for pointing out the existing issue and the prompt support on
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349331#comment-16349331
]
Billie Rinaldi commented on YARN-7677:
--
bq. In the general case, we're not going to be able to order
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349305#comment-16349305
]
Jim Brennan commented on YARN-7677:
---
I have tested a version of the patch where I write out the
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349301#comment-16349301
]
Jason Lowe commented on YARN-7677:
--
YARN-5714 is very relevant here. In the general case, we're not going
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349168#comment-16349168
]
Jim Brennan commented on YARN-7677:
---
Agreed - given that we are just processing the hash map in order, it
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349119#comment-16349119
]
Shane Kumpf commented on YARN-7677:
---
I'm not sure if it will be appropriate to address here, but I think
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349117#comment-16349117
]
Jim Brennan commented on YARN-7677:
---
Thanks [~shaneku...@gmail.com] and [~billie.rinaldi], I will try out
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349085#comment-16349085
]
Hudson commented on YARN-7677:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13598 (See
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349042#comment-16349042
]
Shane Kumpf commented on YARN-7677:
---
[~Jim_Brennan] - Thanks for the update. [~billie.rinaldi] and I have
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349024#comment-16349024
]
Jim Brennan commented on YARN-7677:
---
[~shaneku...@gmail.com], [~jlowe], [~ebadger] I have verified that
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348898#comment-16348898
]
Jim Brennan commented on YARN-7677:
---
[~shaneku...@gmail.com], I am trying to repro locally. In my dev
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348876#comment-16348876
]
Eric Badger commented on YARN-7677:
---
If all AMs are failing in [~shaneku...@gmail.com]'s case, shouldn't
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348841#comment-16348841
]
Jason Lowe commented on YARN-7677:
--
Ultimately one way to debug this would be to compare the container
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348815#comment-16348815
]
Shane Kumpf commented on YARN-7677:
---
Docker is enabled, but the applications in question are not
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348810#comment-16348810
]
Jason Lowe commented on YARN-7677:
--
Is this with Docker containers or without? There are two main changes
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348795#comment-16348795
]
Jim Brennan commented on YARN-7677:
---
[~shaneku...@gmail.com] are you running with docker?
> Docker image
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348779#comment-16348779
]
Shane Kumpf commented on YARN-7677:
---
[~Jim_Brennan], thanks for putting this together. With this patch
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348684#comment-16348684
]
Jim Brennan commented on YARN-7677:
---
Thanks [~jlowe] I will put up a patch for branch-2.
> Docker image
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347283#comment-16347283
]
Hudson commented on YARN-7677:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13591 (See
71 matches
Mail list logo
