[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370822#comment-16370822 ] Carlo Curino commented on YARN-7798: Cherry-picked back to branch-3 with a clean cherry-pick (and spot

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340103#comment-16340103 ] Hudson commented on YARN-7798: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13559 (See

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340085#comment-16340085 ] Yufei Gu commented on YARN-7798: Committed to trunk. Thanks [~youchen] for the patch. > Refactor SLS

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340081#comment-16340081 ] Yufei Gu commented on YARN-7798: +1. Will commit soon. > Refactor SLS Reservation Creation >

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339801#comment-16339801 ] genericqa commented on YARN-7798: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338833#comment-16338833 ] Yufei Gu commented on YARN-7798: Yes. We can use Java8 features in trunk. Please clean the unused imports.

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338643#comment-16338643 ] genericqa commented on YARN-7798: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338596#comment-16338596 ] Young Chen commented on YARN-7798: -- Accidentally generated wrong patch - resubmitting

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338585#comment-16338585 ] genericqa commented on YARN-7798: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338578#comment-16338578 ] Young Chen commented on YARN-7798: -- Submitted v2 patch - Good catch on the componentwiseMax, that actually

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338495#comment-16338495 ] Yufei Gu commented on YARN-7798: Thanks for filing this. [~youchen]. Looks good to me generally. Some nits:

[jira] [Commented] (YARN-7798) Refactor SLS Reservation Creation

[ https://issues.apache.org/jira/browse/YARN-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336805#comment-16336805 ] genericqa commented on YARN-7798: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||