[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479788#comment-16479788
]
Hudson commented on YARN-8080:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14225 (See
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479668#comment-16479668
]
genericqa commented on YARN-8080:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479526#comment-16479526
]
Suma Shivaprasad commented on YARN-8080:
Fixed some more checkstyle issues
> YARN native service
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478317#comment-16478317
]
genericqa commented on YARN-8080:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478235#comment-16478235
]
Suma Shivaprasad commented on YARN-8080:
Thanks [~eyang] Have addressed review comments for
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477665#comment-16477665
]
Eric Yang commented on YARN-8080:
-
[~suma.shivaprasad] {quote}
{quote}
restart_policy=ON_FAILURE, and each
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476933#comment-16476933
]
genericqa commented on YARN-8080:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476854#comment-16476854
]
Suma Shivaprasad commented on YARN-8080:
Thanks [~eyang] Fixed all review comments and quite a few
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476621#comment-16476621
]
Eric Yang commented on YARN-8080:
-
[~suma.shivaprasad] Thank you for the patch, a few nitpicks:
{code}
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475254#comment-16475254
]
genericqa commented on YARN-8080:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475243#comment-16475243
]
genericqa commented on YARN-8080:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475188#comment-16475188
]
Suma Shivaprasad commented on YARN-8080:
Attached patch with fixes to
1. Request containers
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472779#comment-16472779
]
genericqa commented on YARN-8080:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472653#comment-16472653
]
Suma Shivaprasad commented on YARN-8080:
Fixed UT failure/some checkstyle issues
> YARN native
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472604#comment-16472604
]
Suma Shivaprasad commented on YARN-8080:
Thanks [~csingh] Addressed review comments and merged with
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471037#comment-16471037
]
genericqa commented on YARN-8080:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470953#comment-16470953
]
Chandni Singh commented on YARN-8080:
-
# TestComponent
line 250 - 252,
{code}
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470944#comment-16470944
]
Chandni Singh commented on YARN-8080:
-
#
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470899#comment-16470899
]
Suma Shivaprasad commented on YARN-8080:
Thanks [~billie.rinaldi] Thats a good suggestion to add a
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470766#comment-16470766
]
Billie Rinaldi commented on YARN-8080:
--
Hi [~suma.shivaprasad], thanks for the new patch. I like the
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469992#comment-16469992
]
genericqa commented on YARN-8080:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469986#comment-16469986
]
genericqa commented on YARN-8080:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469942#comment-16469942
]
Suma Shivaprasad commented on YARN-8080:
Thanks [~billie.rinaldi] for reviewing the patch. Attached
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466315#comment-16466315
]
Billie Rinaldi commented on YARN-8080:
--
Another thing we should address is the concept of readiness
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466169#comment-16466169
]
Billie Rinaldi commented on YARN-8080:
--
Thanks for taking this up, [~suma.shivaprasad]! This is an
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464158#comment-16464158
]
Eric Yang commented on YARN-8080:
-
[~suma.shivaprasad] Thank you for the patch.
Flex is a black box
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463195#comment-16463195
]
genericqa commented on YARN-8080:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463104#comment-16463104
]
Suma Shivaprasad commented on YARN-8080:
Attached updated patch with review comments for flex
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463097#comment-16463097
]
Suma Shivaprasad commented on YARN-8080:
Thanks [~gsaha] for reviews and offline discussions on the
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455546#comment-16455546
]
genericqa commented on YARN-8080:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455547#comment-16455547
]
Wangda Tan commented on YARN-8080:
--
Following spec can be used to do tests:
{code}
{
"version": "100",
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455540#comment-16455540
]
Suma Shivaprasad commented on YARN-8080:
[~leftnoteasy] As we discussed offline , I can take a look
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455539#comment-16455539
]
Wangda Tan commented on YARN-8080:
--
Attached ver.6 patch, addressed all comments from Gour except
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419991#comment-16419991
]
Gour Saha commented on YARN-8080:
-
It will also be great if you can add the example of Tensorflow using
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419986#comment-16419986
]
Gour Saha commented on YARN-8080:
-
Also, in YARN-Simplified-V1-API-Layer-For-Services.yaml change
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419984#comment-16419984
]
Gour Saha commented on YARN-8080:
-
[~leftnoteasy], few comments:
h5. ServiceMaster.java
remove unnecessary
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419499#comment-16419499
]
Eric Yang commented on YARN-8080:
-
[~leftnoteasy] I did exactly as shown, but it failed to submit through
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418197#comment-16418197
]
Wangda Tan commented on YARN-8080:
--
[~gsaha] / [~eyang] / [~billie.rinaldi] any suggestions?
> YARN
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417990#comment-16417990
]
genericqa commented on YARN-8080:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417861#comment-16417861
]
Wangda Tan commented on YARN-8080:
--
Attached ver.005 patch, which added tests to cover single component /
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416489#comment-16416489
]
genericqa commented on YARN-8080:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416343#comment-16416343
]
Wangda Tan commented on YARN-8080:
--
[~eyang], thanks for reviewing the patch, following is snippet of
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416237#comment-16416237
]
Eric Yang commented on YARN-8080:
-
[~leftnoteasy] Thank you for the patch. enum RestartPolicyEnum spacing
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416147#comment-16416147
]
genericqa commented on YARN-8080:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416062#comment-16416062
]
Wangda Tan commented on YARN-8080:
--
Thanks @Eric yang pointed offline, uploaded a correct patch (002).
>
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416054#comment-16416054
]
genericqa commented on YARN-8080:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416042#comment-16416042
]
Wangda Tan commented on YARN-8080:
--
Attached ver.001 patch. This added handling for all 3 component
47 matches
Mail list logo
