[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442741#comment-16442741
]
Akira Ajisaka commented on YARN-8169:
-
+1, thanks [~belugabehr]!
> Review RackResolver.java
>
[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442506#comment-16442506
]
BELUGA BEHR commented on YARN-8169:
---
[~ajisakaa] Checkstyle corrected :)
> Review RackResolver.java
>
[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442482#comment-16442482
]
genericqa commented on YARN-8169:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442456#comment-16442456
]
Wangda Tan commented on YARN-8169:
--
[~belugabehr], thanks for the clarification, very helpful!
> Review
[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442403#comment-16442403
]
BELUGA BEHR commented on YARN-8169:
---
[~leftnoteasy]
Parameters are best for slf4j:
# Avoids
[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442087#comment-16442087
]
Wangda Tan commented on YARN-8169:
--
[~belugabehr],
it's better to keep the:
{code:java}
if
[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442013#comment-16442013
]
Akira Ajisaka commented on YARN-8169:
-
Cancelling my +1.
Would you add period to the end of the javadoc
[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442005#comment-16442005
]
Akira Ajisaka commented on YARN-8169:
-
LGTM, +1
> Review RackResolver.java
>
[
https://issues.apache.org/jira/browse/YARN-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441135#comment-16441135
]
genericqa commented on YARN-8169:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
