[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983250#comment-16983250
]
Sunil G commented on YARN-8373:
---
Yes [~pbacsko] we need this till 3.1 if possible.
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979004#comment-16979004
]
Peter Bacsko commented on YARN-8373:
[~sunilg] don't we need this patch to branch-3.2 also?
> RM
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978955#comment-16978955
]
Wangda Tan commented on YARN-8373:
--
Thanks [~wilfreds] for the patch and everybody for the review!
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977911#comment-16977911
]
Wilfred Spiegelenburg commented on YARN-8373:
-
I missed the dot instead of the dash. Thank you
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977576#comment-16977576
]
Hadoop QA commented on YARN-8373:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977493#comment-16977493
]
Sunil G commented on YARN-8373:
---
I think its the name. it should have been branch-3.1. Let me reupload.
>
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977415#comment-16977415
]
Wilfred Spiegelenburg commented on YARN-8373:
-
Not sure why it tried to use trunk as the patch
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977312#comment-16977312
]
Hadoop QA commented on YARN-8373:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977269#comment-16977269
]
Hudson commented on YARN-8373:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17663 (See
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977241#comment-16977241
]
Sunil G commented on YARN-8373:
---
+1, thanks [~wilfreds]
> RM Received RMFatalEvent of type
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976997#comment-16976997
]
Wilfred Spiegelenburg commented on YARN-8373:
-
{quote}[~wilfreds] cud we add a test to check
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976615#comment-16976615
]
Sunil G commented on YARN-8373:
---
[~wilfreds] cud we add a test to check whether reading from nodes doesnt
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976389#comment-16976389
]
Peter Bacsko commented on YARN-8373:
Thanks [~wilfreds] now it looks solid. +1 (non-binding) again
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976236#comment-16976236
]
Hadoop QA commented on YARN-8373:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976205#comment-16976205
]
Wilfred Spiegelenburg commented on YARN-8373:
-
{quote}1. Javadoc still says "PriorityQueue":
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975731#comment-16975731
]
Peter Bacsko commented on YARN-8373:
Just two little things:
1. Javadoc still says "PriorityQueue":
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975730#comment-16975730
]
Peter Bacsko commented on YARN-8373:
Thanks [~wilfreds] for explaining. If that is the case, let's
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975722#comment-16975722
]
Hadoop QA commented on YARN-8373:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975692#comment-16975692
]
Wilfred Spiegelenburg commented on YARN-8373:
-
I really should have looked at my fix in
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975689#comment-16975689
]
Wilfred Spiegelenburg commented on YARN-8373:
-
I missed that in the {{PriorityQueue}}. Not
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975404#comment-16975404
]
Peter Bacsko commented on YARN-8373:
[~wilfreds] I have some concerns regarding the use of
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972181#comment-16972181
]
Adam Antal commented on YARN-8373:
--
Thanks for the patch [~wilfreds]. Reading through your analysis and
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971887#comment-16971887
]
Wilfred Spiegelenburg commented on YARN-8373:
-
See my comment:
{quote}
The one inside the
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971655#comment-16971655
]
kailiu_dev commented on YARN-8373:
--
ok ，as you say: "The one inside the scheduler prevents updates of
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971642#comment-16971642
]
Wilfred Spiegelenburg commented on YARN-8373:
-
The one inside the scheduler prevents updates
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971523#comment-16971523
]
kailiu_dev commented on YARN-8373:
--
Dear， [~wilfreds] ,
why you use {color:#00}readLock.lock()
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970388#comment-16970388
]
Hadoop QA commented on YARN-8373:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970386#comment-16970386
]
Hadoop QA commented on YARN-8373:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970241#comment-16970241
]
Wilfred Spiegelenburg commented on YARN-8373:
-
patch-003 to fix the imports the IDE had
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970224#comment-16970224
]
Wilfred Spiegelenburg commented on YARN-8373:
-
Your link points to code in master not in
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969823#comment-16969823
]
Hadoop QA commented on YARN-8373:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969797#comment-16969797
]
Miklos Szegedi commented on YARN-8373:
--
Thank you [~wilfreds] for the patch. Is this patch against
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969741#comment-16969741
]
Wilfred Spiegelenburg commented on YARN-8373:
-
YARN-6448 introduces the synchronisation around
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496085#comment-16496085
]
Miklos Szegedi commented on YARN-8373:
--
This seems to be a race condition. Lots of parameters may
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495045#comment-16495045
]
Girish Bhat commented on YARN-8373:
---
[~miklos.szeg...@cloudera.com]
I can particularly see this when
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494646#comment-16494646
]
Miklos Szegedi commented on YARN-8373:
--
This example samples the unallocated resource just once, so
[
https://issues.apache.org/jira/browse/YARN-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494637#comment-16494637
]
Miklos Szegedi commented on YARN-8373:
--
It seems that SchedulerNode.unallocatedResource can change
37 matches
Mail list logo
