[jira] [Commented] (YARN-8415) TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail

2018-06-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510114#comment-16510114 ] genericqa commented on YARN-8415: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8415) TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail

2018-06-12 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509989#comment-16509989 ] Sunil Govindan commented on YARN-8415: -- Thanks [~suma.shivaprasad]. Patch looks fine. Pending

[jira] [Commented] (YARN-8415) TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail

2018-06-12 Thread Suma Shivaprasad (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509974#comment-16509974 ] Suma Shivaprasad commented on YARN-8415: Thanks [~sunilg] Addressed review comments. There is an

[jira] [Commented] (YARN-8415) TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail

2018-06-12 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509288#comment-16509288 ] Sunil Govindan commented on YARN-8415: -- Thanks [~suma.shivaprasad]  Overall patch looks fine. Few

[jira] [Commented] (YARN-8415) TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail

2018-06-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509103#comment-16509103 ] genericqa commented on YARN-8415: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8415) TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail

2018-06-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509080#comment-16509080 ] genericqa commented on YARN-8415: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8415) TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail

2018-06-11 Thread Suma Shivaprasad (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509057#comment-16509057 ] Suma Shivaprasad commented on YARN-8415: Removed logging of domainId for getEntity calls since it