[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718141#comment-13718141 ] Hadoop QA commented on YARN-875: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713315#comment-13713315 ] Hadoop QA commented on YARN-875: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-16 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710132#comment-13710132 ] Zhijie Shen commented on YARN-875: -- +1 onError(Throwable). However, does it belong to the

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-16 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710136#comment-13710136 ] Bikas Saha commented on YARN-875: - We should not ignore any exceptions unless there is a

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-16 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710207#comment-13710207 ] Zhijie Shen commented on YARN-875: -- IMHO, users know best about the implementations of

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-16 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710344#comment-13710344 ] Bikas Saha commented on YARN-875: - If users have done their homework then the libraries

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-16 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710357#comment-13710357 ] Bikas Saha commented on YARN-875: - wrt NMClientAsync, we should probably check if silently

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709370#comment-13709370 ] Hadoop QA commented on YARN-875: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709408#comment-13709408 ] Hadoop QA commented on YARN-875: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-15 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709461#comment-13709461 ] Xuan Gong commented on YARN-875: fix -1 on javadoc Application can hang if

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709470#comment-13709470 ] Hadoop QA commented on YARN-875: {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-09 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703540#comment-13703540 ] Bikas Saha commented on YARN-875: - Its fine to catch the Throwable and report an error to

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-09 Thread Bikas Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703543#comment-13703543 ] Bikas Saha commented on YARN-875: - We should also augment the javadoc onError() to say that

[jira] [Commented] (YARN-875) Application can hang if AMRMClientAsync callback thread has exception

2013-07-08 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702933#comment-13702933 ] Xuan Gong commented on YARN-875: For the callback, we can catch Throwable, and call