[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646886#comment-16646886
]
Hudson commented on YARN-8777:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15180 (See
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646670#comment-16646670
]
Billie Rinaldi commented on YARN-8777:
--
+1 for patch 8. Thanks for the patch [~eyang] and for the
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645847#comment-16645847
]
Hadoop QA commented on YARN-8777:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645775#comment-16645775
]
Eric Yang commented on YARN-8777:
-
Patch 8 addressed [~billie.rinaldi]'s comments.
> Container Executor C
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645165#comment-16645165
]
Billie Rinaldi commented on YARN-8777:
--
I tested out patch 7. A couple of minor comments: I was
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642220#comment-16642220
]
Zian Chen commented on YARN-8777:
-
+1 for patch 7.
> Container Executor C binary change to execute
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638874#comment-16638874
]
Hadoop QA commented on YARN-8777:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638762#comment-16638762
]
Eric Yang commented on YARN-8777:
-
Unit test failure is addressed in YARN-8844. Patch 7 fixed the white
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638734#comment-16638734
]
Zian Chen commented on YARN-8777:
-
Hi [~eyang], thanks for patch 006. Seems we still have whitespace
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638615#comment-16638615
]
Hadoop QA commented on YARN-8777:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638503#comment-16638503
]
Eric Yang commented on YARN-8777:
-
Patch 6 fixes white space, and cc return code check. TestNMProxy unit
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637697#comment-16637697
]
Hadoop QA commented on YARN-8777:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637645#comment-16637645
]
Eric Yang commented on YARN-8777:
-
Patch 005 rebase code to current trunk.
> Container Executor C binary
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637561#comment-16637561
]
Hadoop QA commented on YARN-8777:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637447#comment-16637447
]
Eric Yang commented on YARN-8777:
-
Patch 004 added pseudo terminal support for running with docker exec
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637151#comment-16637151
]
Eric Yang commented on YARN-8777:
-
[~Zian Chen] Docker exec -it requires a tty to be attached for program
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623999#comment-16623999
]
Zian Chen commented on YARN-8777:
-
Thanks [~eyang] for the work. I'm ok with patch 003. One quick
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623951#comment-16623951
]
Eric Badger commented on YARN-8777:
---
I'm +1 (non-binding) on patch 003
> Container Executor C binary
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623900#comment-16623900
]
Eric Yang commented on YARN-8777:
-
[~ebadger] Sounds good to me. [~Zian Chen] [~ebadger]
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623675#comment-16623675
]
Eric Badger commented on YARN-8777:
---
Ok I see what you're saying. I'm fine with the modifications to
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622850#comment-16622850
]
Eric Yang commented on YARN-8777:
-
[~ebadger] I am confused by your statement. We have been using comma
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622690#comment-16622690
]
Eric Badger commented on YARN-8777:
---
Thanks for the updated patch, [~eyang]!
{noformat}
+
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621322#comment-16621322
]
Hadoop QA commented on YARN-8777:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621278#comment-16621278
]
Eric Yang commented on YARN-8777:
-
[~Zian Chen] [~ebadger] Patch 3 will change the .cmd file format to
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621259#comment-16621259
]
Eric Yang commented on YARN-8777:
-
Base on today's meeting, there is possibility that bash doesn't exist
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621059#comment-16621059
]
Eric Yang commented on YARN-8777:
-
[~ebadger] {quote}Where do the shell expansion cases come from? We
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620989#comment-16620989
]
Eric Badger commented on YARN-8777:
---
bq. Shell expansion corner cases will not handle gracefully and
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620969#comment-16620969
]
Hadoop QA commented on YARN-8777:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620831#comment-16620831
]
Eric Yang commented on YARN-8777:
-
[~Zian Chen] Patch 002 fixed comment in the header file.
> Container
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620815#comment-16620815
]
Eric Yang commented on YARN-8777:
-
[~ebadger] {quote}Opening up a bash session allows the user to then
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620751#comment-16620751
]
Eric Badger commented on YARN-8777:
---
bq. The enum approach can be used for fixed number of parameters or
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620077#comment-16620077
]
Eric Yang commented on YARN-8777:
-
[~Zian Chen] {quote}
The method param list have out an outlen which
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619569#comment-16619569
]
Zian Chen commented on YARN-8777:
-
Hi [~eyang], thanks for the patch, some quick suggestions and
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617950#comment-16617950
]
Eric Yang commented on YARN-8777:
-
[~ebadger] The patch is written for specific use case while making
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617780#comment-16617780
]
Eric Badger commented on YARN-8777:
---
Do we want to always force the exec to be {{-it bash}}? I know the
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615535#comment-16615535
]
Hadoop QA commented on YARN-8777:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615506#comment-16615506
]
Eric Yang commented on YARN-8777:
-
To run a interactive test, create a cmd file for container executor
37 matches
Mail list logo
