[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-20 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773570#comment-16773570 ] Zhankun Tang commented on YARN-9060: [~jojochuang] , Thanks for reporting this. I'll check it ASAP. >

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-20 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773319#comment-16773319 ] Wei-Chiu Chuang commented on YARN-9060: --- i am not sure why but the code fails to compile after this

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770983#comment-16770983 ] Hudson commented on YARN-9060: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15986 (See

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-18 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770980#comment-16770980 ] Zhankun Tang commented on YARN-9060: [~sunilg], [~cheersyang], Thanks for the reviews! > [YARN-8851]

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-17 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770419#comment-16770419 ] Sunil Govindan commented on YARN-9060: -- +1. Lets get this in > [YARN-8851] Phase 1 - Support device

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-12 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766109#comment-16766109 ] Zhankun Tang commented on YARN-9060: [~sunilg] , the failed test cases seems not related. Please

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766012#comment-16766012 ] Hadoop QA commented on YARN-9060: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758604#comment-16758604 ] Hadoop QA commented on YARN-9060: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758368#comment-16758368 ] Zhankun Tang commented on YARN-9060: [~sunilg] , Thanks. And there's indeed a potential issue that it

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758364#comment-16758364 ] Sunil Govindan commented on YARN-9060: -- Yes, snprintf ensures a trailing /0 and hence this existing

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758357#comment-16758357 ] Zhankun Tang commented on YARN-9060: [~sunilg] , Thanks for mentioning this good question. >From what

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758240#comment-16758240 ] Weiwei Yang commented on YARN-9060: --- TestConfigurationNodeAttributesProvider UT failure should not be

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758200#comment-16758200 ] Sunil Govindan commented on YARN-9060: -- Hi [~tangzhankun] Sorry for this late comments. I have some

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-02-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758078#comment-16758078 ] Hadoop QA commented on YARN-9060: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-31 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757952#comment-16757952 ] Zhankun Tang commented on YARN-9060: [~sunilg] , Thanks for the review! {quote}In below comments, it's

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757694#comment-16757694 ] Hadoop QA commented on YARN-9060: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757040#comment-16757040 ] Hadoop QA commented on YARN-9060: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-30 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756896#comment-16756896 ] Sunil Govindan commented on YARN-9060: -- Thanks [~tangzhankun]  Few comments. # In below comments,

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756482#comment-16756482 ] Hadoop QA commented on YARN-9060: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-30 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756238#comment-16756238 ] Zhankun Tang commented on YARN-9060: [~cheersyang] , Thanks for the review! For point 1, added the

[jira] [Commented] (YARN-9060) [YARN-8851] Phase 1 - Support device isolation and use the Nvidia GPU plugin as an example

2019-01-30 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755941#comment-16755941 ] Weiwei Yang commented on YARN-9060: ---   Hi [~tangzhankun] Please take a look at my comments: