[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921218#comment-16921218
]
Peter Bacsko commented on YARN-9477:
[~jojochuang] thanks for informing me about this and following-up
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919857#comment-16919857
]
Wei-Chiu Chuang commented on YARN-9477:
---
For future reference, when you add a new dependency, please
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873478#comment-16873478
]
Hudson commented on YARN-9477:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16825 (See
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873458#comment-16873458
]
Peter Bacsko commented on YARN-9477:
OK, now patch is should be good. Unit test failure is unrelated.
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873460#comment-16873460
]
Zhankun Tang commented on YARN-9477:
[~snemeth], thanks for the review. [~pbacsko], Thanks for the
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873437#comment-16873437
]
Hadoop QA commented on YARN-9477:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872661#comment-16872661
]
Hadoop QA commented on YARN-9477:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872392#comment-16872392
]
Hadoop QA commented on YARN-9477:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871498#comment-16871498
]
Hadoop QA commented on YARN-9477:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871192#comment-16871192
]
Peter Bacsko commented on YARN-9477:
[~tangzhankun] [~snemeth] please verify the latest patch.
Main
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833892#comment-16833892
]
Hadoop QA commented on YARN-9477:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833891#comment-16833891
]
Szilard Nemeth commented on YARN-9477:
--
Thanks [~pbacsko]!
+1 (non-binding) for the latest patch!
>
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833805#comment-16833805
]
Peter Bacsko commented on YARN-9477:
[~snemeth] thanks for the comments, patch v3 fixes these.
>
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833686#comment-16833686
]
Szilard Nemeth commented on YARN-9477:
--
Hi [~pbacsko]!
Thanks for this patch!
The test classes look
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832570#comment-16832570
]
Prabhu Joseph commented on YARN-9477:
-
[~pbacsko] Yes this is introduced by YARN-6929. Will be fixed
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832510#comment-16832510
]
Peter Bacsko commented on YARN-9477:
Test failure seems to be unrelated to this patch. Instead, it was
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832505#comment-16832505
]
Hadoop QA commented on YARN-9477:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831668#comment-16831668
]
Hadoop QA commented on YARN-9477:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831631#comment-16831631
]
Peter Bacsko commented on YARN-9477:
[~snemeth] could you please check patch v1?
> Implement VE
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831605#comment-16831605
]
Peter Bacsko commented on YARN-9477:
I uploaded the first version of this.
I immediately realized two
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830306#comment-16830306
]
Szilard Nemeth commented on YARN-9477:
--
Thanks [~pbacsko] for the quick update!
The latest patch of
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830297#comment-16830297
]
Peter Bacsko commented on YARN-9477:
Thanks [~snemeth] for the comments.
_In
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830272#comment-16830272
]
Szilard Nemeth commented on YARN-9477:
--
Hi [~pbacsko]!
Some comments:
1. In UdevUtil#getSysPath: the
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826085#comment-16826085
]
Peter Bacsko commented on YARN-9477:
[~tangzhankun] [~snemeth] could you please check out this POC?
>
[
https://issues.apache.org/jira/browse/YARN-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826084#comment-16826084
]
Peter Bacsko commented on YARN-9477:
Note that this part is the heart of the improvement:
{code}
25 matches
Mail list logo
