Allen Wittenauer created YARN-3484:
--------------------------------------

             Summary: Fix up yarn top shell code
                 Key: YARN-3484
                 URL: https://issues.apache.org/jira/browse/YARN-3484
             Project: Hadoop YARN
          Issue Type: Bug
          Components: scripts
    Affects Versions: 3.0.0
            Reporter: Allen Wittenauer


We need to do some work on yarn top's shell code.

a) Just checking for TERM isn't good enough.  We really need to check the 
return on tput, especially since the output will not be a number but an error 
string which will likely blow up the java code in horrible ways.

b) All the single bracket tests should be double brackets to force the bash 
built-in.

c) I'd think I'd rather see the shell portion in a function since it's rather 
large.  This will allow for args, etc, to get local'ized and clean up the case 
statement.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to